Repository navigation
feat(connections): browse and add datasets from the Connections tree #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b297004
feat(connections): browse and add datasets from the Connections tree …
deniial00 ba63e66
feat(connections): add the selection from a dataset's menu instead of…
deniial00 f782b0a
docs: say where Add With Options… is offered in the Connections tree
deniial00 a5d0afc
fix(connections): address review of the Connections tree
deniial00 2fe961b
test(connections): cover the answer size limit, long catalogue links …
deniial00 4c35706
feat(connections): list a static STAC catalog's items, each opened fo…
deniial00 a6e3938
test(connections): a static item's relative asset address resolves ag…
deniial00 1227ed5
fix(connections): address second review round
deniial00 571eb13
Merge origin/main into browsing-adding-connections
deniial00 a4f0e7d
fix(connections): address third review round
deniial00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit (low confidence):
add_withused to be empty for an unknown kind and was per-kind guidance. It's now one string for every kind, and it no longer says that S3 needsconnection.loginfirst when credentials are keys.connection.browsedoes return that hint on error, so this is only a discoverability loss. The per-kind guidance also told the assistant the underlying commands (stac.search,service.coverage), which it can no longer see. Consider keeping a short per-kind hint.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept as is: the plan asks for one
addWithhint for every kind, andconnection.browsenames the next step itself (its errors say to log in first, and each child carries the command that adds it), so a per-kind list would only repeat what browsing returns.