Skip to content

rosa-aws-hcp-conformance: skip two flaky Netpol tests (CORENET-1882) - #83479

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:rosa-hcp-skip-netpol-tests
Aug 15, 2026
Merged

rosa-aws-hcp-conformance: skip two flaky Netpol tests (CORENET-1882)#83479
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
redhat-chai-bot:rosa-hcp-skip-netpol-tests

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Skip two NetworkPolicy (Netpol) conformance tests in the ROSA HCP workflow that have been failing persistently due to a known upstream timing issue tracked in CORENET-1882.

Details

The job periodic-ci-openshift-release-main-nightly-4.20-e2e-rosa-hcp-ovn has a 14.3% pass rate over the last 14 days (2 of 14 runs passed), with 10 consecutive failures since Aug 6. Both blocking failures are NetworkPolicy tests timing out at the 930s ceiling:

  • [sig-network] Netpol NetworkPolicy between server and client should deny ingress access to updated pod
  • [sig-network] Netpol NetworkPolicy between server and client should stop enforcing policies after they are deleted

These tests fail because they check pod connectivity immediately after a policy is created, before the network plugin has fully enforced it — a known race condition documented in CORENET-1882.

A similar Netpol test (should allow ingress access from updated pod) is already skipped in this workflow. This PR adds the two remaining failing tests to the same skip list.

Suspected regression trigger

The failure streak correlates with several networking PRs landing in the 4.20 nightly around Aug 4-5:

Tracking

  • CORENET-1882 — upstream NetworkPolicy enforcement timing issue
  • OCPQE-31074 — umbrella task for ROSA HCP 4.20 test failures
  • OCPQE-30405 — Network_Edge 4.20 e2e debugging

AI-generated. Review for accuracy.

@dustman9000 requested in Slack thread

Summary by CodeRabbit

The ROSA HCP conformance workflow now skips two persistently failing NetworkPolicy tests. This prevents known upstream timing failures tracked in CORENET-1882 from reducing workflow reliability.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d5f8ca1e-b37f-4816-aeca-0588294ab0ad

📥 Commits

Reviewing files that changed from the base of the PR and between 1ef5a7f and 77e2555.

📒 Files selected for processing (1)
  • ci-operator/step-registry/rosa/aws/hcp/conformance/rosa-aws-hcp-conformance-workflow.yaml

Walkthrough

The ROSA AWS HCP conformance workflow adds two NetworkPolicy test patterns to TEST_SKIPS. The existing ingress-allowance scenario remains listed.

Changes

ROSA HCP conformance workflow

Layer / File(s) Summary
NetworkPolicy test skip configuration
ci-operator/step-registry/rosa/aws/hcp/conformance/rosa-aws-hcp-conformance-workflow.yaml
Adds skips for ingress denial after pod updates and policy enforcement after NetworkPolicy deletion.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 77e25

This change only updates the ROSA HCP conformance workflow to skip two known-flaky NetworkPolicy tests; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: dustman9000

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the two skipped flaky NetworkPolicy tests and references the tracking issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR adds only two literal, descriptive NetworkPolicy skip names; neither contains generated identifiers, timestamps, node or namespace names, IPs, or other dynamic values.
Test Structure And Quality ✅ Passed The pull request changes only two TEST_SKIPS entries in a workflow YAML; it adds no Ginkgo test code, resource setup, waits, or assertions to assess.
Microshift Test Compatibility ✅ Passed The commit changes only one workflow YAML file by adding two TEST_SKIPS entries; it adds no Ginkgo tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only the ROSA HCP YAML TEST_SKIPS list; it adds no Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only adds two NetworkPolicy test names to TEST_SKIPS; it adds no deployment, controller, replica, affinity, node-selection, taint, or PDB scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The diff changes only two TEST_SKIPS entries in a ROSA HCP YAML workflow; it adds no OTE binary code or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff changes only a workflow YAML skip list and adds no Ginkgo tests or networking code, so this compatibility check is not applicable.
No-Weak-Crypto ✅ Passed The diff only adds two NetworkPolicy skip-list strings. It introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, crypto implementation, or secret comparison.
Container-Privileges ✅ Passed The patch only adds two NetworkPolicy names to TEST_SKIPS and introduces no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation setting.
No-Sensitive-Data-In-Logs ✅ Passed The diff adds only two NetworkPolicy test-name entries to TEST_SKIPS; it introduces no logging statements, credentials, tokens, PII, hostnames, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-5.0-e2e-rosa-hcp-ovn N/A periodic Registry content changed
periodic-ci-openshift-release-main-nightly-5.1-e2e-rosa-hcp-ovn N/A periodic Registry content changed
periodic-ci-openshift-release-main-nightly-4.19-e2e-rosa-hcp-ovn N/A periodic Registry content changed
periodic-ci-openshift-release-main-nightly-4.21-e2e-rosa-hcp-ovn N/A periodic Registry content changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-rosa-hcp-ovn N/A periodic Registry content changed
periodic-ci-openshift-release-main-nightly-4.20-e2e-rosa-hcp-ovn N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustman9000

Copy link
Copy Markdown
Member

/lgtm
/approve
/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 15, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2026
@openshift-ci

openshift-ci Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit a6b1d5b into openshift:main Aug 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants