Repository navigation
📖 align ClusterObjectSet concept doc with the single Ready condition - #3021
Open
perdasilva wants to merge 1 commit into
Open
perdasilva wants to merge 1 commit into
perdasilva wants to merge 1 commit into
Conversation
The ClusterObjectSet reports only a Ready condition; the Progressing and Succeeded conditions were removed and rollout completion is tracked by the status.completedAt timestamp. Align the concept doc accordingly: - Drop the stale Progressing and Succeeded condition sections. - Note that completion is recorded in status.completedAt (new "Completion" section). - Remove the Migrated Ready reason row (no such reason is emitted). - Add the ProgressDeadlineExceeded Ready reason row, which the controller emits and the API doc already documents but the concept table was missing. - Replace "reports Succeeded" references in the transition/upgrade flows with "rolled out successfully". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align the
ClusterObjectSetconcept doc with the current singleReadycondition model.The ClusterObjectSet reports only a
Readycondition; theProgressingandSucceededconditions were removed, and rollout completion is tracked by thestatus.completedAttimestamp. This updatesdocs/draft/concepts/clusterobjectsets.mdaccordingly:ProgressingandSucceededcondition sections.Completion (status.completedAt)section.MigratedReady-reason row (no such reason is emitted).ProgressDeadlineExceededReady-reason row, which the controller emits and the API doc-string already documents but the concept table was missing.The Ready-reason table now matches the API doc-string's reason set exactly (
AllObjectsReady,ObjectsNotReady,Superseded,ObjectCollision,PreconditionsNotMet,InvalidSpecification,ProgressDeadlineExceeded,Archiving,Archived) — reflecting theValidationFailure → PreconditionsNotMet/InvalidSpecificationsplit (#3017) and theRetryableErrorremoval (#3012), both now inmain.Docs-only change.
🤖 Generated with Claude Code
Summary by CodeRabbit
Succeededstatus.Readyreasons.