Preserve package names inside npm prerelease versions - #236
Open
codewithfourtix wants to merge 1 commit into
Open
Preserve package names inside npm prerelease versions#236codewithfourtix wants to merge 1 commit into
codewithfourtix wants to merge 1 commit into
Conversation
Signed-off-by: Ali Zulfiqar <codewithfourtix@gmail.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, targeted, and the added regression test directly covers the reported parsing bug for both scoped and unscoped npm tarball URLs.
Pull request overview
Fixes npm download URL parsing so that prerelease versions containing the package name (e.g., foo-1.0.0-foo.1.tgz) keep the full prerelease string instead of incorrectly removing embedded name occurrences.
Changes:
- Update npm tarball version extraction to remove only the leading filename prefix (not all occurrences).
- Add regression tests covering both unscoped and scoped npm download URLs for this prerelease pattern.
File summaries
| File | Description |
|---|---|
src/packageurl/contrib/url2purl.py |
Switches version derivation from global replace() to prefix-only removal to preserve prerelease content. |
tests/contrib/test_url2purl.py |
Adds a regression test ensuring scoped/unscoped npm tarball URLs keep -foo.1 in the parsed version. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing
foo-1.0.0-foo.1.tgzcurrently drops both occurrences offoo, changing the version to1.0.0-.1. Remove only the filename prefix so the prerelease version stays intact.Adds regression coverage for scoped and unscoped npm downloads.