Skip to content

Preserve package names inside npm prerelease versions #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codewithfourtix wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

Preserve package names inside npm prerelease versions #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/packageurl/contrib/url2purl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ def build_npm_download_purl(uri):
return

base_filename, ext = os.path.splitext(filename)
version = base_filename.replace(name, "")
version = base_filename.removeprefix(name)
if version.startswith("-"):
version = version[1:] # Removes the "-" prefix

Expand Down
7 changes: 7 additions & 0 deletions tests/contrib/test_url2purl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,10 @@ class TestURL2PURLDataDriven(TestCase):


build_tests(clazz=TestURL2PURLDataDriven, regen=False)


def test_npm_download_preserves_name_in_prerelease_version():
for namespace in ("", "@scope/"):
url = f"https://registry.npmjs.org/{namespace}foo/-/foo-1.0.0-foo.1.tgz"
expected_namespace = "%40scope/" if namespace else ""
assert get_purl(url) == f"pkg:npm/{expected_namespace}foo@1.0.0-foo.1"