Repository navigation
ui: drop the create form's unused Boot mode and show create progress - #1249
Merged
Merged
Conversation
The sandbox create form offered a Boot mode select (cold boot, snapshot, pool) that never reached the API: the handler dropped the field and the create request has no such option, so choosing "Pool" or "Snapshot" changed nothing. It is removed. The Create button had no in-flight state, so a second click during a slow request submitted a second create under a new idempotency key. It now shows progress and ignores repeat submits until the request settles.
|
Thanks for opening this pull request! A SPACE maintainer will take a look. CONTRIBUTING.md explains how we review outside contributions. |
mabdelraouf-pplx
approved these changes
Oct 31, 2026
zibi-pplx
previously approved these changes
Nov 1, 2026
zibi-pplx
dismissed
their stale review
November 1, 2026 22:30
Withdrawing this approval for now. Any feedback above still stands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes a create-form control that did nothing, and stops a slow create from being submitted twice.
handleCreatedropped the value, and the create request (POST /api/v1/sandboxes, or the admin create for another org) has no such field. Choosing "Pool" or "Snapshot" changed nothing. Warm-pool boot mode on the Templates page is a different, real setting and is unchanged.The disabled gVisor, Cloud Hypervisor and Hyper-V runtime options are left alone on purpose. The execution spec defines some of those runtime kinds, and whether to show them is a product decision.
Stack
Independent of the other open console PRs. It edits the create form in
ui/src/app/dashboard/sandboxes/page.tsx, which #1244 and #1248 also edit elsewhere; whichever merges later may need a small rebase.Validation
npm ci,npm test(50 pass) andnpm run buildinui/.main(production build) and on this branch (the Kindspace-uiimage). The create flow holds the create request for 1.5 s with Playwright route interception, then checks that the button shows progress and that the form has no Boot mode field. It then runs the full lifecycle on the created sandbox, ending in delete.main.Visual confirmation
Severity and risk
Severity: low.
Risk: low. The removed control had no effect. Roll back by reverting the commit.
AI assistance: Claude Code wrote the code and this description, and ran the validation; a maintainer reviews it.