Skip to content

ui: drop the create form's unused Boot mode and show create progress #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ac-pplx merged 1 commit into from
Nov 2, 2026
+9 −9
Merged

ui: drop the create form's unused Boot mode and show create progress #1249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions ui/src/app/dashboard/sandboxes/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,8 @@ function SandboxesPage() {
const [editingLifecycleSandbox, setEditingLifecycleSandbox] = useState<Sandbox | null>(null);
const [editingNetworkSandbox, setEditingNetworkSandbox] = useState<Sandbox | null>(null);
const [manualRefreshing, setManualRefreshing] = useState(false);
const [creating, setCreating] = useState(false);
const creatingRef = useRef(false);
const [refreshCooldown, setRefreshCooldown] = useState(false);
const [nowMs, setNowMs] = useState(() => Date.now());
const refreshCooldownRef = useRef(false);
Expand Down Expand Up @@ -750,9 +752,11 @@ function SandboxesPage() {
org_id?: string;
template: string;
runtime: string;
boot_mode?: string;
snapshots?: boolean;
}) => {
if (creatingRef.current) return;
creatingRef.current = true;
setCreating(true);
try {
const payload = {
name: values.name || null,
Expand Down Expand Up @@ -821,6 +825,9 @@ function SandboxesPage() {
});
} catch (err: any) {
message.error(err.message);
} finally {
creatingRef.current = false;
setCreating(false);
}
};

Expand Down Expand Up @@ -1210,13 +1217,6 @@ function SandboxesPage() {
))}
</Select>
</Form.Item>
<Form.Item name="boot_mode" style={{ marginBottom: 0 }}>
<Select placeholder="Boot mode" style={{ width: 140 }} allowClear>
<Select.Option value="cold">Cold boot</Select.Option>
<Select.Option value="snapshot">Snapshot</Select.Option>
<Select.Option value="pool">Pool</Select.Option>
</Select>
</Form.Item>
<Form.Item name="snapshots" valuePropName="checked" style={{ marginBottom: 0 }}>
<Checkbox>Snapshots</Checkbox>
</Form.Item>
Expand All @@ -1229,7 +1229,7 @@ function SandboxesPage() {
Clear
</Button>
) : null}
<Button type="primary" htmlType="submit" icon={<PlusOutlined />}>Create</Button>
<Button type="primary" htmlType="submit" icon={<PlusOutlined />} loading={creating}>Create</Button>
</Space>
</div>
</Form>
Expand Down
Loading