Skip to content

refactor: remove unreachable renderer and manifest resolver branches, retain filesystem race protection, and reach 100% code coverage without reflection-based tests. - #3

Merged
terabytesoftw merged 1 commit into
mainfrom
refactor/remove-unreacheable-renderer-and-manifest-resolver
Aug 24, 2026
Merged

Conversation

@terabytesoftw

Copy link
Copy Markdown
Contributor

Pull Request

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bugfix (non-breaking change that fixes an issue)
  • CI/build configuration
  • Documentation update
  • New feature (non-breaking change that adds functionality)
  • Refactoring (no functional changes)

… retain filesystem race protection, and reach `100%` code coverage without reflection-based tests.
@terabytesoftw terabytesoftw added the bug Something isn't working label Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 14 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 80c30aa0-2c92-4fa2-8cec-c270960e7fa8

📥 Commits

Reviewing files that changed from the base of the PR and between 61ec27c and 2902bef.

📒 Files selected for processing (21)
  • CHANGELOG.md
  • composer.json
  • phpunit.xml.dist
  • src/Asset/AssetCollection.php
  • src/Configuration/DevelopmentConfiguration.php
  • src/Exception/Message.php
  • src/Html/HtmlRenderOptions.php
  • src/Html/HtmlRenderer.php
  • src/Manifest/ManifestLoader.php
  • src/Resolver/ManifestAssetResolver.php
  • src/Vite.php
  • tests/AssetCollectionTest.php
  • tests/ConfigurationTest.php
  • tests/Fixture/duplicate-file-manifest.json
  • tests/HtmlRendererTest.php
  • tests/ManifestLoaderTest.php
  • tests/Provider/ConfigurationProvider.php
  • tests/Provider/HtmlRendererProvider.php
  • tests/Support/InternalMockerExtension.php
  • tests/Support/internal-mocker-stubs.php
  • tests/ViteProductionTest.php

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (61ec27c) to head (2902bef).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff              @@
##               main        #3      +/-   ##
=============================================
+ Coverage     94.18%   100.00%   +5.81%     
+ Complexity      210       208       -2     
=============================================
  Files            19        19              
  Lines           533       516      -17     
=============================================
+ Hits            502       516      +14     
+ Misses           31         0      -31     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@terabytesoftw

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 2902bef31e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@terabytesoftw
terabytesoftw merged commit 1f8cb97 into main Aug 24, 2026
41 checks passed
@terabytesoftw
terabytesoftw deleted the refactor/remove-unreacheable-renderer-and-manifest-resolver branch August 24, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant