Compatibility with PHP 8.6.0beta1 - #18
Conversation
. ZEND_LTOA() (and ZEND_LTOA_BUF_LEN) has been removed, as it was
unsafe. Directly use ZEND_LONG_FMT with a function from the
printf family.
. The zval_dtor() alias of zval_ptr_dtor_nogc() has been removed.
Call zval_ptr_dtor_nogc() directly instead.
. The XtOffsetOf() alias of C’s offsetof() macro has been removed. Use
offsetof() directly.
|
|
|
@somethingwithproof this PR is strictly to fix build with 8.6 (minimal) I won't have much time before next week to look at this BTW, who still cares about 32-bit ? :p ;) |
|
No worries, I was just pushing up my local work. I agree with you about 32 bit but you know there's somebody out there I guess. |
|
Keeping #18 to the minimal PHP 8.6 build fix makes sense. I will let this land first, then rebase my stack and remove the overlap from #14. The wider timestamp handling in #12 will remain separate: it addresses the existing buffer overflow and the fetch-loop width issue, with regression coverage, rather than being required for the 8.6 build. No rush on reviewing the rest before next week. |
Tested with PHP 7.0 and 8.6.0beta1