Add mobile package name to js_xlr_pipeline - #121
Draft
cehan-Chloe wants to merge 3 commits into
Draft
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xlr_compile already stamps a package's npm name into manifest.json via XLR_PACKAGE_NAME (added in the prior commit). This adds the same for iOS and Android, so a plugin's manifest can carry all three platform names in one place instead of just the npm one.
Any key can be omitted — only the platforms present get an env var (XLR_PACKAGE_NAME / XLR_IOS_PACKAGE_NAME / XLR_ANDROID_PACKAGE_NAME) set on the compile action, matching how a plugin without a mobile counterpart works today. An unrecognized key (e.g. a typo) fails the build immediately with a clear error, rather than being silently dropped.
Verified: built //plugins/reference-assets/react:react_xlr in the player-ui/player repo (via local_path_override) with --stamp, and confirmed the generated manifest.json contains matching react/ios/android entries with the same stamped version. Also rebuilt all 6 existing js_xlr_pipeline consumers in that repo to confirm no regression — the 5 without the new args still emit react-only manifests.