Change no thermostat schedule defined representation#899
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThermostat schedule handling now uses ChangesSchedule off standardization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3508 3502 -6
=========================================
- Hits 3508 3502 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|



At present, no thermostat schedule defined result in:
available_schedules = []selected_schedule = NoneIn HA this will lead to the related Select not being shown.
When a user defines a schedule, this change will not be picked up automatically by the Plugwise integration. An integration-reload will be required to show the user-update.
Proposed solution: show
offas a the single option when no schedule is defined. This should result in the Select being present with no other options to select. When the user creates a schedule the change should automatically be picked up.Summary by CodeRabbit
Summary by CodeRabbit
Bug Fixes
Documentation