Skip to content

Change no thermostat schedule defined representation #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bouwew merged 9 commits into from
Jul 20, 2026
Merged

Change no thermostat schedule defined representation #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
77aa9c1
Rework select_schedule to default off when no schedule active
bouwew Jul 19, 2026
12b11e8
Rework json-file to match the code update
bouwew Jul 19, 2026
01e8ec6
Update available_schedules order: off to first position
bouwew Jul 19, 2026
d627e4a
Save updated fixtures
bouwew Jul 19, 2026
25d43fd
Same rework for legacy
bouwew Jul 19, 2026
2d50119
Save update legacy device fixtures
bouwew Jul 19, 2026
3efb7ea
Cleanup
bouwew Jul 19, 2026
f68d8d6
Save updated manual fixtures
bouwew Jul 19, 2026
30103db
Update CHANGELOG
bouwew Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Ongoing

- Change representation of no-thermostat-schedule-defined to a single `off` option via PR [#899](https://github.com/plugwise/python-plugwise/pull/899)

## v1.14.1

- Improve manual fixtures script, reorder set_schedule_state() arguments for better compatibility with set_dhw_mode(), via PR[#897](https://github.com/plugwise/python-plugwise/pull/897)
Expand Down
6 changes: 4 additions & 2 deletions fixtures/adam_bad_thermostat/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@
},
"3ee6b9486cb04c258a3130fff2b144a4": {
"active_preset": "home",
"available_schedules": [],
"available_schedules": [
"off"
],
"climate_mode": "heat",
"control_state": "idle",
"dev_class": "climate",
Expand All @@ -58,7 +60,7 @@
"vacation",
"no_frost"
],
"select_schedule": null,
"select_schedule": "off",
"sensors": {
"temperature": 20.3
},
Expand Down
40 changes: 20 additions & 20 deletions fixtures/adam_heatpump_cooling/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
"04b15f6e884448288f811d29fb7b1b30": {
"active_preset": "away",
"available_schedules": [
"off",
"Opstaan weekdag",
"Werkdag schema",
"Weekend",
"off"
"Weekend"
],
"climate_mode": "cool",
"control_state": "idle",
Expand Down Expand Up @@ -141,10 +141,10 @@
"20e735858f8146cead98b873177a4f99": {
"active_preset": "away",
"available_schedules": [
"off",
"Opstaan weekdag",
"Werkdag schema",
"Weekend",
"off"
"Weekend"
],
"climate_mode": "cool",
"control_state": "idle",
Expand Down Expand Up @@ -269,10 +269,10 @@
"5cc21042f87f4b4c94ccb5537c47a53f": {
"active_preset": "away",
"available_schedules": [
"off",
"Opstaan weekdag",
"Werkdag schema",
"Weekend",
"off"
"Weekend"
],
"climate_mode": "auto",
"control_state": "idle",
Expand Down Expand Up @@ -429,10 +429,10 @@
"8cf650a4c10c44819e426bed406aec34": {
"active_preset": "away",
"available_schedules": [
"off",
"Opstaan weekdag",
"Werkdag schema",
"Weekend",
"off"
"Weekend"
],
"climate_mode": "auto",
"control_state": "idle",
Expand Down Expand Up @@ -475,10 +475,10 @@
"93ac3f7bf25342f58cbb77c4a99ac0b3": {
"active_preset": "away",
"available_schedules": [
"off",
"Opstaan weekdag",
"Werkdag schema",
"Weekend",
"off"
"Weekend"
],
"climate_mode": "cool",
"control_state": "idle",
Expand Down Expand Up @@ -540,10 +540,10 @@
"9a27714b970547ee9a6bdadc2b815ad5": {
"active_preset": "away",
"available_schedules": [
"off",
"Opstaan weekdag",
"Werkdag schema",
"Weekend",
"off"
"Weekend"
],
"climate_mode": "cool",
"control_state": "idle",
Expand Down Expand Up @@ -606,10 +606,10 @@
"a562019b0b1f47a4bde8ebe3dbe3e8a9": {
"active_preset": "away",
"available_schedules": [
"off",
"Opstaan weekdag",
"Werkdag schema",
"Weekend",
"off"
"Weekend"
],
"climate_mode": "auto",
"control_state": "idle",
Expand Down Expand Up @@ -652,10 +652,10 @@
"b52908550469425b812c87f766fe5303": {
"active_preset": "away",
"available_schedules": [
"off",
"Opstaan weekdag",
"Werkdag schema",
"Weekend",
"off"
"Weekend"
],
"climate_mode": "cool",
"control_state": "idle",
Expand Down Expand Up @@ -796,10 +796,10 @@
"e39529c79ab54fda9bed26cfc0447546": {
"active_preset": "away",
"available_schedules": [
"off",
"Opstaan weekdag",
"Werkdag schema",
"Weekend",
"off"
"Weekend"
],
"climate_mode": "cool",
"control_state": "idle",
Expand Down Expand Up @@ -912,10 +912,10 @@
"fa5fa6b34f6b40a0972988b20e888ed4": {
"active_preset": "away",
"available_schedules": [
"off",
"Opstaan weekdag",
"Werkdag schema",
"Weekend",
"off"
"Weekend"
],
"climate_mode": "auto",
"control_state": "idle",
Expand Down
24 changes: 16 additions & 8 deletions fixtures/adam_jip/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
{
"06aecb3d00354375924f50c47af36bd2": {
"active_preset": "no_frost",
"available_schedules": [],
"available_schedules": [
"off"
],
"climate_mode": "heat",
"control_state": "idle",
"dev_class": "climate",
Expand All @@ -14,7 +16,7 @@
"vacation",
"no_frost"
],
"select_schedule": null,
"select_schedule": "off",
"select_zone_profile": "active",
"sensors": {
"temperature": 24.2
Expand Down Expand Up @@ -42,7 +44,9 @@
},
"13228dab8ce04617af318a2888b3c548": {
"active_preset": "home",
"available_schedules": [],
"available_schedules": [
"off"
],
"climate_mode": "heat",
"control_state": "idle",
"dev_class": "climate",
Expand All @@ -55,7 +59,7 @@
"vacation",
"no_frost"
],
"select_schedule": null,
"select_schedule": "off",
"select_zone_profile": "active",
"sensors": {
"temperature": 27.4
Expand Down Expand Up @@ -282,7 +286,9 @@
},
"d27aede973b54be484f6842d1b2802ad": {
"active_preset": "home",
"available_schedules": [],
"available_schedules": [
"off"
],
"climate_mode": "heat",
"control_state": "idle",
"dev_class": "climate",
Expand All @@ -295,7 +301,7 @@
"vacation",
"no_frost"
],
"select_schedule": null,
"select_schedule": "off",
"select_zone_profile": "active",
"sensors": {
"temperature": 30.0
Expand Down Expand Up @@ -347,7 +353,9 @@
},
"d58fec52899f4f1c92e4f8fad6d8c48c": {
"active_preset": "home",
"available_schedules": [],
"available_schedules": [
"off"
],
"climate_mode": "heat",
"control_state": "idle",
"dev_class": "climate",
Expand All @@ -360,7 +368,7 @@
"vacation",
"no_frost"
],
"select_schedule": null,
"select_schedule": "off",
"select_zone_profile": "active",
"sensors": {
"temperature": 30.0
Expand Down
20 changes: 10 additions & 10 deletions fixtures/adam_multiple_devices_per_zone/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@
"08963fec7c53423ca5680aa4cb502c63": {
"active_preset": "away",
"available_schedules": [
"off",
"CV Roan",
"Bios Schema met Film Avond",
"GF7 Woonkamer",
"Badkamer Schema",
"CV Jessie",
"off"
"CV Jessie"
],
"climate_mode": "auto",
"control_state": "idle",
Expand Down Expand Up @@ -64,12 +64,12 @@
"12493538af164a409c6a1c79e38afe1c": {
"active_preset": "away",
"available_schedules": [
"off",
"CV Roan",
"Bios Schema met Film Avond",
"GF7 Woonkamer",
"Badkamer Schema",
"CV Jessie",
"off"
"CV Jessie"
],
"climate_mode": "heat",
"control_state": "idle",
Expand Down Expand Up @@ -129,12 +129,12 @@
"446ac08dd04d4eff8ac57489757b7314": {
"active_preset": "no_frost",
"available_schedules": [
"off",
"CV Roan",
"Bios Schema met Film Avond",
"GF7 Woonkamer",
"Badkamer Schema",
"CV Jessie",
"off"
"CV Jessie"
],
"climate_mode": "heat",
"control_state": "idle",
Expand Down Expand Up @@ -285,12 +285,12 @@
"82fa13f017d240daa0d0ea1775420f24": {
"active_preset": "asleep",
"available_schedules": [
"off",
"CV Roan",
"Bios Schema met Film Avond",
"GF7 Woonkamer",
"Badkamer Schema",
"CV Jessie",
"off"
"CV Jessie"
],
"climate_mode": "auto",
"control_state": "idle",
Expand Down Expand Up @@ -440,12 +440,12 @@
"c50f167537524366a5af7aa3942feb1e": {
"active_preset": "home",
"available_schedules": [
"off",
"CV Roan",
"Bios Schema met Film Avond",
"GF7 Woonkamer",
"Badkamer Schema",
"CV Jessie",
"off"
"CV Jessie"
],
"climate_mode": "auto",
"control_state": "heating",
Expand Down
4 changes: 2 additions & 2 deletions fixtures/adam_onoff_cooling_fake_firmware/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@
"fa5fa6b34f6b40a0972988b20e888ed4": {
"active_preset": "away",
"available_schedules": [
"off",
"Opstaan weekdag",
"Werkdag schema",
"Weekend",
"off"
"Weekend"
],
"climate_mode": "auto",
"control_state": "idle",
Expand Down
4 changes: 2 additions & 2 deletions fixtures/adam_plus_anna/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"009490cc2f674ce6b576863fbb64f867": {
"active_preset": "home",
"available_schedules": [
"Weekschema",
"off"
"off",
"Weekschema"
],
"climate_mode": "auto",
"control_state": "idle",
Expand Down
8 changes: 4 additions & 4 deletions fixtures/adam_plus_anna_new/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,11 +302,11 @@
"f2bf9048bef64cc5b6d5110154e33c81": {
"active_preset": "home",
"available_schedules": [
"off",
"Badkamer",
"Vakantie",
"Weekschema",
"Test",
"off"
"Test"
],
"climate_mode": "auto",
"control_state": "heating",
Expand Down Expand Up @@ -351,11 +351,11 @@
"f871b8c4d63549319221e294e4f88074": {
"active_preset": "vacation",
"available_schedules": [
"off",
"Badkamer",
"Vakantie",
"Weekschema",
"Test",
"off"
"Test"
],
"climate_mode": "heat",
"control_state": "idle",
Expand Down
8 changes: 4 additions & 4 deletions fixtures/adam_plus_anna_new_regulation_off/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,11 +254,11 @@
"f2bf9048bef64cc5b6d5110154e33c81": {
"active_preset": "home",
"available_schedules": [
"off",
"Badkamer",
"Test",
"Vakantie",
"Weekschema",
"off"
"Weekschema"
],
"climate_mode": "off",
"control_state": "idle",
Expand Down Expand Up @@ -301,11 +301,11 @@
"f871b8c4d63549319221e294e4f88074": {
"active_preset": "home",
"available_schedules": [
"off",
"Badkamer",
"Test",
"Vakantie",
"Weekschema",
"off"
"Weekschema"
],
"climate_mode": "off",
"control_state": "idle",
Expand Down
Loading