Fix subtest reruns with structured NodeId keys - #363
Open
janmrow wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest-dev/pytest#14758 changed how pytest stores node IDs internally: instead of strings, it now uses
NodeIdobjects.Because of this, the private
failed_subtestsmapping usesNodeIdobjects as keys.pytest-rerunfailureswas still looking up failed subtests using string.nodeidvalues. So that failed subtests were not rerun with newer pytest versions.This change uses
.idwhenNodeIdis available, and falls back to.nodeidfor older pytest versions.Tested locally:
431f3e1f5,Only the
failed_subtestshandling was changed. Other uses of.nodeidstay the same.