Repository navigation
perf: lazy loading - #43
Merged
Merged
Conversation
…into perf/lazy-loading
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces lazy loading for the RFC3987 grammar and parser objects to reduce import-time overhead, continuing prior work on performance improvements.
Changes:
- Replace eager module-level grammar/parser initialization with lazy, lock-protected getters.
- Add module-level
__getattr__/__dir__to lazily exposegrammarandsyntax_parseras public attributes. - Document the performance change in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/rfc3987_syntax2/syntax_helpers.py | Implements lazy initialization for grammar/parser and lazy-loaded public module attributes. |
| CHANGELOG.md | Notes the new lazy-loading behavior under Unreleased changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lazy-load expensive public symbols.
continues the work of willynilly#8