Repository navigation
perf: lazy loading #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
310cc75
Lazy-load syntax validators on attr access
djrobstep 7053a73
Also create the syntax parser lazily
djrobstep 9b74fe0
Merge remote-tracking branch 'djrobstep/lazy-load-syntax-validators' …
jkowalleck 79249cb
revert
jkowalleck 28647ff
add __all__
jkowalleck e2b657c
lsazy-load
jkowalleck 90f515f
lsazy-load
jkowalleck cd78af2
locks
jkowalleck ffa216f
docs
jkowalleck cb166c4
imp
jkowalleck 34f8a14
docs
jkowalleck 8a1f79c
test: add regression tests for lazy-loaded grammar and syntax_parser …
Copilot f5e48f3
Merge remote-tracking branch 'origin/main' into perf/lazy-loading
jkowalleck fe47336
Merge branch 'main' into perf/lazy-loading
jkowalleck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Copyright (c) 2025 Will Riley - original author | ||
| # Copyright (c) 2026 Jan Kowalleck - modifications and maintenance | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| import rfc3987_syntax2 as sut | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Copyright (c) 2026 Jan Kowalleck - modifications and maintenance | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| import rfc3987_syntax2 as sut | ||
| from lark import Lark | ||
|
|
||
|
|
||
| def test_grammar_is_accessible() -> None: | ||
| """Regression test: grammar is lazily loaded and accessible as a module attribute.""" | ||
| assert isinstance(sut.grammar, str) | ||
| assert len(sut.grammar) > 0 | ||
|
|
||
|
|
||
| def test_syntax_parser_is_accessible() -> None: | ||
| """Regression test: syntax_parser is lazily loaded and accessible as a module attribute.""" | ||
| assert isinstance(sut.syntax_parser, Lark) | ||
|
|
||
|
|
||
| def test_grammar_in_dir() -> None: | ||
| """Regression test: grammar appears in dir(rfc3987_syntax2).""" | ||
| assert "grammar" in dir(sut) | ||
|
|
||
|
|
||
| def test_syntax_parser_in_dir() -> None: | ||
| """Regression test: syntax_parser appears in dir(rfc3987_syntax2).""" | ||
| assert "syntax_parser" in dir(sut) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.