Repository navigation
Add type checks to checks target and fix integration coverage glob - #207
Merged
Merged
Conversation
Every variant's checks target runs check-types, and the compiled modules get .pyi stubs so ty resolves them. The coverage omit for integration tests is a glob; a bare directory path matches no file. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
timkpaine
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every variant's
checkstarget now runscheck-typesalongsidecheck-dist. The compiled modules (cython_native,cppextension,cppjswasmextension_cpp) get one-line.pyistubs so ty resolves them; without the stubs the cython render fails on._native. Each variant was rendered from this branch and type-checked the way its Makefile does.The coverage
omitentry for integration tests is a glob,tests/integration/*; the bare directory path matched no file.Replaces #206, which carried untracked symlinks from the local checkout. This branch touches the 19 template files only.