Skip to content

Add type checks to checks target and fix integration coverage glob #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timkpaine merged 1 commit into from
Oct 8, 2026
Merged

Add type checks to checks target and fix integration coverage glob #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/cpp/Makefile.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ check-dist: ## check python sdist and wheel with check-dist
check-types: ## check python types with ty
ty check --python $$(which python)

checks: check-dist
checks: check-dist check-types

# alias
check: checks
Expand Down
2 changes: 1 addition & 1 deletion python/cpp/pyproject.toml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ test-requires = ["pytest"]
[tool.coverage.run]
branch = true
omit = [
"{{ module }}/tests/integration/",
"{{ module }}/tests/integration/*",
]

[tool.coverage.report]
Expand Down
1 change: 1 addition & 0 deletions python/cpp/{{module}}/extension.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
def add(i: int, j: int) -> int: ...
2 changes: 1 addition & 1 deletion python/cppjswasm/Makefile.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ check-dist: ## check python sdist and wheel with check-dist
check-types: ## check python types with ty
ty check --python $$(which python)

checks: check-dist
checks: check-dist check-types

# alias
check: checks
Expand Down
2 changes: 1 addition & 1 deletion python/cppjswasm/pyproject.toml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ test-requires = ["pytest"]
[tool.coverage.run]
branch = true
omit = [
"{{ module }}/tests/integration/",
"{{ module }}/tests/integration/*",
]

[tool.coverage.report]
Expand Down
1 change: 1 addition & 0 deletions python/cppjswasm/{{module}}/extension_cpp.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
def add(i: int, j: int) -> int: ...
2 changes: 1 addition & 1 deletion python/cython/Makefile.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ check-dist: ## check python sdist and wheel with check-dist
check-types: ## check Python types (advisory)
ty check {{ module }}

checks: check-dist ## run distribution checks
checks: check-dist check-types ## run distribution checks
check: checks

test: ## run Python tests
Expand Down
2 changes: 1 addition & 1 deletion python/cython/pyproject.toml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ replace = 'version = "{new_version}"'
[tool.coverage.run]
branch = true
omit = [
"{{ module }}/tests/integration/",
"{{ module }}/tests/integration/*",
"{{ module }}/_compiled.py",
]

Expand Down
1 change: 1 addition & 0 deletions python/cython/{{module}}/_native.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
def add(left: int, right: int) -> int: ...
2 changes: 1 addition & 1 deletion python/js/Makefile.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ check-dist: ## check python sdist and wheel with check-dist
check-types: ## check python types with ty
ty check --python $$(which python)

checks: check-dist
checks: check-dist check-types

# alias
check: checks
Expand Down
2 changes: 1 addition & 1 deletion python/js/pyproject.toml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ replace = '"version": "{new_version}"'
[tool.coverage.run]
branch = true
omit = [
"{{ module }}/tests/integration/",
"{{ module }}/tests/integration/*",
]

[tool.coverage.report]
Expand Down
2 changes: 1 addition & 1 deletion python/jupyter/Makefile.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ check-dist: ## check python sdist and wheel with check-dist
check-types: ## check python types with ty
ty check --python $$(which python)

checks: check-dist
checks: check-dist check-types

# alias
check: checks
Expand Down
2 changes: 1 addition & 1 deletion python/jupyter/pyproject.toml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ replace = '"version": "{new_version}"'
[tool.coverage.run]
branch = true
omit = [
"{{ module }}/tests/integration/",
"{{ module }}/tests/integration/*",
]

[tool.coverage.report]
Expand Down
2 changes: 1 addition & 1 deletion python/pure/Makefile.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ check-dist: ## check python sdist and wheel with check-dist
check-types: ## check python types with ty
ty check --python $$(which python)

checks: check-dist
checks: check-dist check-types

# Alias
check: checks
Expand Down
2 changes: 1 addition & 1 deletion python/pure/pyproject.toml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ replace = 'version = "{new_version}"'
[tool.coverage.run]
branch = true
omit = [
"{{ module }}/tests/integration/",
"{{ module }}/tests/integration/*",
]

[tool.coverage.report]
Expand Down
2 changes: 1 addition & 1 deletion python/rust/Makefile.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ check-dist: ## check python sdist and wheel with check-dist
check-types: ## check python types with ty
ty check --python $$(which python)

checks: check-dist
checks: check-dist check-types

# alias
check: checks
Expand Down
2 changes: 1 addition & 1 deletion python/rust/pyproject.toml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ xbuild-tools = ["cargo", "rustc", "rustup"]
[tool.coverage.run]
branch = true
omit = [
"{{ module }}/tests/integration/",
"{{ module }}/tests/integration/*",
]

[tool.coverage.report]
Expand Down
2 changes: 1 addition & 1 deletion python/rustjswasm/Makefile.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ check-dist: ## check python sdist and wheel with check-dist
check-types: ## check python types with ty
ty check --python $$(which python)

checks: check-dist
checks: check-dist check-types

# alias
check: checks
Expand Down
2 changes: 1 addition & 1 deletion python/rustjswasm/pyproject.toml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ xbuild-tools = ["cargo", "rustc", "rustup"]
[tool.coverage.run]
branch = true
omit = [
"{{ module }}/tests/integration/",
"{{ module }}/tests/integration/*",
]

[tool.coverage.report]
Expand Down
Loading