Repository navigation
Conversation
Fromager refuses to start when --network-isolation is given but the platform cannot support it, for example under Docker's default seccomp profile, which blocks the unshare syscall. The only workaround is to drop the flag entirely. Downgrade the hard failure to a warning and disable isolation for the rest of the run so builds are not blocked by runner limitations. Signed-off-by: Emilien Macchi <emacchi@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
this was an experiment, do not merge it. |
Summary
When
--network-isolationis given on a runner that cannot support it (for example Docker's default seccomp profile, which blocks theunsharesyscall), fromager fails at startup with no workaround other than dropping the flag entirely.This downgrades the hard failure to a warning and continues with isolation disabled for the rest of the run.
Testing
tests/test_external_commands.pyandtests/test_cli.pypass