Skip to content

fix(cli): continue without network isolation when unavailable #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EmilienM wants to merge 1 commit into from
Closed

fix(cli): continue without network isolation when unavailable #1379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/fromager/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,15 @@ def main(
hooks.log_hooks()

if network_isolation and not SUPPORTS_NETWORK_ISOLATION:
ctx.fail(f"network isolation is not available: {NETWORK_ISOLATION_ERROR}")
# Some CI runners (for example Docker's default seccomp profile)
# block the unshare syscall, which made fromager fail at startup
# with no workaround. Warn and continue without isolation instead
# of blocking the build.
logger.warning(
"network isolation is not available: %s; continuing without it",
NETWORK_ISOLATION_ERROR,
)
network_isolation = False

wkctx = context.WorkContext(
active_settings=packagesettings.Settings.from_files(
Expand Down
Loading