Repository navigation
gh-159561: Remove redundant type check in AF_VSOCK setsockopt() - #159610
Merged
Merged
Conversation
benjaminp
reviewed
Oct 17, 2026
benjaminp
left a comment
benjaminp
left a comment
Contributor
There was a problem hiding this comment.
Does it work to delete this whole block? PyArg_Parse will validate.
lazerg
changed the title
Contributor
Author
|
Yes, it works. The |
benjaminp
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AF_VSOCK branch of
sock_setsockopt()set aTypeErrorfor a non-int option value but kept going, soPyArg_Parse()ran with an exception already pending. The check is redundant since theKconverter already rejects non-int values, so I removed it.Fixes #159561
AF_VSOCKsetsockoptvalidation code #159561