Skip to content

gh-159561: Remove redundant type check in AF_VSOCK setsockopt() #159610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjaminp merged 2 commits into from
Oct 18, 2026
+0 −5
Merged

gh-159561: Remove redundant type check in AF_VSOCK setsockopt() #159610

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f050971
gh-159561: Return early on non-int optval in AF_VSOCK setsockopt()
lazerg Oct 17, 2026
2b7ac5a
Drop the AF_VSOCK type check, PyArg_Parse already validates
lazerg Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions Modules/socketmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3420,11 +3420,6 @@ sock_setsockopt(PyObject *self, PyObject *args)

#ifdef AF_VSOCK
if (s->sock_family == AF_VSOCK) {
if (!PyIndex_Check(optval)) {
PyErr_Format(PyExc_TypeError,
"setsockopt() argument 3 for AF_VSOCK must be an int (got %T)",
optval);
}
uint64_t vflag; // Must be set width of 64 bits
/* setsockopt(level, opt, flag) */
if (!PyArg_Parse(optval, "K", &vflag)) {
Expand Down
Loading