fix(ios26): avoid Ionic lazy-loader imports - #262
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| @@ -1,5 +1,5 @@ | |||
| import { createIosTransitionAnimation, shadow } from '@rdlabo/ionic-theme-utils'; | |||
| import type { Animation } from '@ionic/core'; | |||
| import type { Animation } from '@ionic/core/components'; | |||
There was a problem hiding this comment.
🔍 依存先更新後にバンドルを再確認する
公開エントリーポイントから利用するポップオーバーと画面遷移は、固定依存の utils を実行時に読み込みます。対応版を採用するまでは、遅延ローダーがバンドルから除去されたか確認できません。
Was this helpful? React with 👍 or 👎 to provide feedback.
Playwright test results
Details
|
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-262/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-262/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-262/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-ios26@9.4.1-beta.pr262.shaf7be836783c4 |
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-262/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
1 participant
Runtime imports from
@ionic/corepull Ionic's lazy-loader build into custom-element applications. This applies the import fix from #261 to theios26branch: animation, gesture, and lifecycle utilities use@ionic/core/components/index.js, while types use type-only imports from@ionic/core/components.Only imports change; behavior, package versions, and the lockfile are unchanged. This removes the theme's direct root imports; the shared utils dependency still needs its corresponding published update (rdlabo-dev/ionic-theme-utils#6).
Validation:
Many thanks to @NgLoader for the excellent work identifying the bundle-size issue and providing the import fixes that this PR brings to iOS 26.
Closes #259