Skip to content

fix(ios26): avoid Ionic lazy-loader imports #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdlabo merged 1 commit into from
Oct 2, 2026
Merged

fix(ios26): avoid Ionic lazy-loader imports #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/popover/animations/ios.enter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { createAnimation } from '@ionic/core';
import type { Animation } from '@ionic/core';
import { createAnimation } from '@ionic/core/components/index.js';
import type { Animation } from '@ionic/core/components';
import {
calculateWindowAdjustment,
createCalloutSurface,
Expand Down
4 changes: 2 additions & 2 deletions src/popover/animations/ios.leave.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { createAnimation } from '@ionic/core';
import { createAnimation } from '@ionic/core/components/index.js';
import { getElementRoot } from '../../utils';

import type { Animation } from '@ionic/core';
import type { Animation } from '@ionic/core/components';

/**
* iOS Popover Leave Animation
Expand Down
4 changes: 2 additions & 2 deletions src/sheets-of-glass/animations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { Animation, AnimationKeyFrames } from '@ionic/core';
import type { Animation, AnimationKeyFrames, GestureDetail } from '@ionic/core/components';
import { AnimationPosition, EffectScales } from './interfaces';
import { createAnimation, GestureDetail } from '@ionic/core';
import { createAnimation } from '@ionic/core/components/index.js';
import { getStep } from '../utils';

export const getScaleAnimation = (effectElement: Element): Animation => {
Expand Down
4 changes: 2 additions & 2 deletions src/sheets-of-glass/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { AnimationPosition, EffectScales, registeredEffect } from './interfaces';
import { createAnimation, createGesture } from '@ionic/core';
import type { Animation, Gesture, GestureDetail } from '@ionic/core';
import { createAnimation, createGesture } from '@ionic/core/components/index.js';
import type { Animation, Gesture, GestureDetail } from '@ionic/core/components';
import { changeSelectedElement, cloneElement, getStep } from '../utils';
import { createMoveAnimation, createPreMoveAnimation, getMoveAnimationKeyframe, getScaleAnimation } from './animations';

Expand Down
3 changes: 2 additions & 1 deletion src/tab-bar-searchable/animations/enter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Animation, createAnimation } from '@ionic/core';
import type { Animation } from '@ionic/core/components';
import { createAnimation } from '@ionic/core/components/index.js';
import { ANIMATION_DELAY_CLOSE_BUTTONS, OPACITY_TRANSITION, type ElementReferences, type ElementSizes } from '@rdlabo/ionic-theme-utils';
import { cloneElement } from '../../utils';

Expand Down
3 changes: 2 additions & 1 deletion src/tab-bar-searchable/animations/leave.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Animation, createAnimation } from '@ionic/core';
import type { Animation } from '@ionic/core/components';
import { createAnimation } from '@ionic/core/components/index.js';
import { ANIMATION_DELAY_CLOSE_BUTTONS, OPACITY_TRANSITION, type ElementReferences, type ElementSizes } from '@rdlabo/ionic-theme-utils';
import { cloneElement } from '../../utils';

Expand Down
2 changes: 1 addition & 1 deletion src/tab-bar-searchable/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createAnimation } from '@ionic/core';
import { createAnimation } from '@ionic/core/components/index.js';
import {
ANIMATION_DELAY_BASE,
ANIMATION_DURATION,
Expand Down
6 changes: 3 additions & 3 deletions src/transition/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { config } from '../utils';
import { Build, writeTask } from '@stencil/core';

import { LIFECYCLE_DID_ENTER, LIFECYCLE_DID_LEAVE, LIFECYCLE_WILL_ENTER, LIFECYCLE_WILL_LEAVE } from '@ionic/core';
import type { NavOptions, NavDirection } from '@ionic/core';
import type { Animation, AnimationBuilder } from '@ionic/core';
import { LIFECYCLE_DID_ENTER, LIFECYCLE_DID_LEAVE, LIFECYCLE_WILL_ENTER, LIFECYCLE_WILL_LEAVE } from '@ionic/core/components/index.js';
import type { NavOptions, NavDirection } from '@ionic/core/components';
import type { Animation, AnimationBuilder } from '@ionic/core/components';
import { createFocusController } from '../focus-controller';
import { raf } from '../utils';

Expand Down
2 changes: 1 addition & 1 deletion src/transition/ios.transition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { createIosTransitionAnimation, shadow } from '@rdlabo/ionic-theme-utils';
import type { Animation } from '@ionic/core';
import type { Animation } from '@ionic/core/components';

@devin-ai-integration devin-ai-integration Bot Oct 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 依存先更新後にバンドルを再確認する

公開エントリーポイントから利用するポップオーバーと画面遷移は、固定依存の utils を実行時に読み込みます。対応版を採用するまでは、遅延ローダーがバンドルから除去されたか確認できません。

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

import type { TransitionOptions } from './index';
import { getIonPageElement } from './index';

Expand Down
2 changes: 1 addition & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { AnimationPosition } from './sheets-of-glass/interfaces';
import { IonicConfig } from '@ionic/core';
import type { IonicConfig } from '@ionic/core/components';

declare const __zone_symbol__requestAnimationFrame: any;
declare const requestAnimationFrame: any;
Expand Down
Loading