Skip to content

reject queries without from clause - #9906

Open
k-anshul wants to merge 1 commit into
mainfrom
metricssql_panic_fix
Open

k-anshul wants to merge 1 commit into
mainfrom
metricssql_panic_fix

Conversation

@k-anshul

@k-anshul k-anshul commented Sep 18, 2026

Copy link
Copy Markdown
Member

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@k-anshul k-anshul self-assigned this Sep 18, 2026

@nishantmonu51 nishantmonu51 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but nit: I have used this to test connectivity in the past, any reason for disallowing it ? Does it not work anymore ?

@k-anshul

k-anshul commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

Approving, but nit: I have used this to test connectivity in the past, any reason for disallowing it ? Does it not work anymore ?

@nishantmonu51 AFAIK select 1 kind of statements never worked using metrics sql because the first step is to identify the metrics view from the from clause.
Did you by chance used normal SQL API instead of metrics sql ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants