Skip to content

reject queries without from clause #9906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
k-anshul wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

reject queries without from clause #9906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions runtime/metricsview/metricssql/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,10 @@ type selectField struct {
}

func (q *query) parseFrom(ctx context.Context, node *ast.TableRefsClause) error {
n := node.TableRefs
if n == nil || n.Left == nil {
if node == nil || node.TableRefs == nil || node.TableRefs.Left == nil {
return fmt.Errorf("metrics sql: need `FROM metrics_view` clause")
}
n := node.TableRefs
if n.Right != nil {
return fmt.Errorf("metrics sql: join is not supported")
}
Expand Down
4 changes: 4 additions & 0 deletions runtime/metricsview/metricssql/parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,10 @@ func TestCompile(t *testing.T) {
"select pub from ad_bids_metrics, ad_bids_metrics_advanced",
"metrics sql: join is not supported",
},
{
"select 1",
"metrics sql: need `FROM metrics_view` clause",
},
}

clm, err := rt.ResolveSecurity(t.Context(), instanceID, claims, mv)
Expand Down
Loading