Repository navigation
fix: remove unbounded Range parsing cache - #78
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The module-level Range cache retains every distinct file-size/header combination for the lifetime of the process. Parse Range headers directly, following Rsbuild, and pass the file size and header separately to avoid building and splitting cache keys. Existing Range and strong-ETag tests cover the behavior without adding new fixtures.
Performance
Local HTTP keep-alive benchmark on Node 24.19.0 / Apple M5 Max, with 16 concurrent requests and separate server/client processes. Seven alternating rounds per scenario; repeated 64 KiB ranges were additionally measured over five longer rounds (2 s warmup, 4 s measurement).
This trades repeated-range parsing cost for bounded retention; these synthetic measurements are not a general throughput guarantee. Status, response bytes, Content-Length and Content-Range were checked. The full suite passed: 4,208 tests, 2 skipped.
Related Links