Skip to content

fix: remove unbounded Range parsing cache #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Oct 22, 2026
Merged

fix: remove unbounded Range parsing cache #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions src/middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,19 +137,14 @@ const statuses = {
500: "Internal Server Error",
};

const parseRangeHeaders = memorize(
/**
* @param {string} value value
* @returns {import("range-parser").Result | import("range-parser").Ranges} ranges
*/
(value) => {
const [len, rangeHeader] = value.split("|");

return rangeParser(Number(len), rangeHeader, {
combine: true,
});
},
);
/**
* @param {number} size file size
* @param {string} rangeHeader Range header
* @returns {import("range-parser").Result | import("range-parser").Ranges} ranges
*/
function parseRangeHeaders(size, rangeHeader) {
return rangeParser(size, rangeHeader, { combine: true });
}

const getETag = memorize(() => etag);
const getEscapeHtml = memorize(() => escapeHtml);
Expand Down Expand Up @@ -692,7 +687,7 @@ function wrapper(context) {
if (rangeHeader) {
const parsedRanges =
/** @type {import("range-parser").Ranges | import("range-parser").Result} */
(parseRangeHeaders(`${size}|${rangeHeader}`));
(parseRangeHeaders(size, rangeHeader));

if (
parsedRanges !== -2 &&
Expand Down Expand Up @@ -795,7 +790,7 @@ function wrapper(context) {
if (rangeHeader) {
let parsedRanges =
/** @type {import("range-parser").Ranges | import("range-parser").Result | []} */
(parseRangeHeaders(`${size}|${rangeHeader}`));
(parseRangeHeaders(size, rangeHeader));

// If-Range support
if (!isRangeFresh()) {
Expand Down
Loading