Repository navigation
JM: Put FileMaker archive buttons beside person and org codes, and link back - #2648
Merged
Merged
Conversation
maebeale
changed the title
maebeale
marked this pull request as ready for review
October 12, 2026 20:58
maebeale
force-pushed
the
maebeale/archive-data-filemaker
branch
from
October 12, 2026 21:00
4cf1e32 to
525f133
Compare
maebeale
changed the title
maebeale
force-pushed
the
maebeale/archive-data-filemaker
branch
4 times, most recently
from
October 12, 2026 23:26
45dd33c to
ddde227
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The archive buttons in the edit-page nav checked only the ?admin=true param, so an owner editing their own profile with it set saw their FileMaker code and a link that 403s. The helper now checks the archive policy, so admin mode no longer needs to gate it. Each model declares which archive table its codes point into, so call sites stop repeating the table and the archive can find the portal records carrying a code. That gives the archive record a way back to the person or org, and an org's edit page a link to the FileMaker agency its project sits under. Codes the archive has no row for render struck through beside the input, flagging a likely typo instead of disappearing. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ck through A nav button reading "Rolodex 00006" repeats the code already beside it; the code only helps when a record has several to tell apart. A missing code's underline was hiding its strikethrough, so it looked like a working link. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Chips beside the input crowded the row; the hint keeps the links with the field they describe without widening it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codes pasted from FileMaker or a spreadsheet carry tabs, line breaks, and non-breaking spaces that broke both the archive links and the archive's link back. Saving stores the sorted comma-space form, so edited records settle into one shape without a backfill. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
That's the name the archive uses for the table it opens. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A nav button for a code the archive has no row for rendered struck through and went nowhere. The top bar now drops those; the code field's hint keeps showing them struck through, where the typo gets fixed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Archive links read the table from the model's declaration, so the ADR's per-call archive:/table: example no longer works. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/archive-data-filemaker
branch
from
October 12, 2026 23:37
ddde227 to
4976121
Compare
…tions An org can carry an ORG… code as well as a P… one, and the prefix is part of the id — P00023 and ORG00023 are different records — so codes are looked up whole, never by their number. ADR-0005 now records each archive table's id pattern as we learn them, since prefixes overlap (P is both projects and participants). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Profiled every archive table's fm_id shape in prod. Project ids are all also valid participant ids, and X/D/numeric ids collide across tables too, which is why codes are looked up whole in their declared tables rather than routed by prefix. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Affiliations almost all carry project codes and resources carry quotation codes, which contradicts the mapping ADR-0005 recorded for them — flagged open rather than flipped. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Their shape fits a project id, but a personnel id missing its S fits too; only checking each row against its person and org can tell. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Nearly every org carries a project code, not an ORG code, so the archive page for an FM organization showed no portal orgs. It now also finds orgs carrying any of its projects' codes, in one query. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Production resource codes are almost all quotation ids on Leader spotlight resources, and nearly all of them exist in the quotations archive. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Checked against each affiliation's own person and org in production: the P-codes are the org's project id, not Personnel ids missing their S. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Each issue type gets a fix; the affected records will be listed by id only, so the ADR never names a record or repeats its code. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Ids and issue type only, from a read-only production run, so the ADR names no record and repeats no code. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 helper + concern seam, admin-only views across people/orgs/archive
Admins can jump straight between a person or org and its FileMaker archive record, in both directions. If there's a code, but it doesn't match, it shows as strikethrough.
Fixes
?admin=true. An owner editing their own profile with that param saw their FileMaker code and a link that 403s.filemaker_archive_linksnow checksallowed_to?(:show?, :fm_archive)and returns nothing otherwise.?admin=truegate is no longer needed.Changes
line-through!so a link class'sunderlinecan't hide it.P00023andORG00023are different records; a bare00023matches neither.ORG…codes plus each project's parent (Project.OrgID), de-duplicated.ORG…code or any of its projects' codes (Project.OrgID).Pis shared by projects and participants, so nothing routes by prefix.fm_archives#showgets an "In the portal" section linking the people/orgs carrying that code.filemaker_archived_in FmRolodexreplaces passingarchive:/table:at every call site.with_filemaker_code(code)usesFIND_IN_SETover the whitespace-stripped list, so000066doesn't match00006.REGEXP_REPLACE … [[:space:]]).;or/aren't separators.normalizes :filemaker_codesaves the sorteda, bform. Existing rows change only when edited — no backfill.Affiliations follow in the stacked #2649.
🤖 Generated with Claude Code