Repository navigation
Show internal notes to admins behind ?admin on people and organizations - #2689
Merged
Merged
Conversation
maebeale
changed the title
People notes held legacy FileMaker comments that only surfaced on the dedupe page; orgs and users already expose theirs behind ?admin. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sentence-case the label; the disabled toggle was dead since the block already requires manage?. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/notes-ux-visibility
branch
from
October 14, 2026 23:59
dcd8416 to
98d3d5a
Compare
maebeale
marked this pull request as ready for review
October 14, 2026 23:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 1 Skim 👀 admin-gated form fields, no logic change
Admins can now see and edit a person's internal notes (legacy FileMaker comments), which until now only showed up on the dedupe page. The org field that was already there now matches it.
What is the goal of this PR and why is this important?
people.noteshad no UI; organizations and users already exposed theirs on the edit form behind?admin.How did you approach the change?
params[:admin]+manage?.notesis inPersonPolicy::ADMIN_ONLY_FIELDS.disabled:toggle (the block already requiresmanage?). Added specs for it.UI Testing Checklist
/people/:id/edit?admin=trueand/organizations/:id/edit?admin=trueas admin show "Internal notes" above the buttons?adminthe field is hidden🤖 Generated with Claude Code