Error on projection of dyn noncompat type in old trait solver - #154992
Error on projection of dyn noncompat type in old trait solver#154992spirali wants to merge 4 commits into
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-compiler
| //~^ ERROR the trait `Foo` is not dyn compatible | ||
| x.method(); | ||
| //~^ ERROR the trait `Foo` is not dyn compatible | ||
| //~^ ERROR no method named `method` found for reference `&dyn Foo` |
There was a problem hiding this comment.
that's annoying :< ideally we'd silence method errors if the self type is not well-formed, tracking that is non-trivial and I don't know how we'd do so myself rn
|
lgtm, let's do a crater run, there should be exactly 1 regression from this @bors try |
This comment has been minimized.
This comment has been minimized.
Error on projection of dyn noncompat type in old trait solver
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
Footnotes
|
craterbot
added
S-waiting-on-review
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
@craterbot p=1 |
|
📝 Configuration of the ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
Footnotes
|
craterbot
added
S-waiting-on-review
|
@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-154992-1/retry-regressed-list.txt p=1 surprising that we have that many spurious regressions still? it's caused by build OOMs and unlike the new solver, this PR shouldn't really change max-rss in any way 😅 cc @rust-lang/infra |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
@rfcbot fcp merge types |
|
@lcnr has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rust-rfcbot
added
proposed-final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rust-rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. |
| let tcx = selcx.tcx(); | ||
| if !tcx.is_dyn_compatible(def_id) { | ||
| let span = obligation.cause.span; | ||
| let guar = if span.is_dummy() |
There was a problem hiding this comment.
comment why we can delay bug here
I guess it's that this should be handled in WF instead?
|
@bors delegate |
|
@bors r=lcnr |
rust-bors
Bot
added
S-waiting-on-bors
Error on projection of dyn noncompat type in old trait solver Trying to fix rust-lang/trait-system-refactor-initiative#269 I am not sure that the check is placed into the right place in the code. r? lcnr
Error on projection of dyn noncompat type in old trait solver Trying to fix rust-lang/trait-system-refactor-initiative#269 I am not sure that the check is placed into the right place in the code. r? lcnr
Error on projection of dyn noncompat type in old trait solver Trying to fix rust-lang/trait-system-refactor-initiative#269 I am not sure that the check is placed into the right place in the code. r? lcnr
Error on projection of dyn noncompat type in old trait solver Trying to fix rust-lang/trait-system-refactor-initiative#269 I am not sure that the check is placed into the right place in the code. r? lcnr
7 participants
View all comments
Trying to fix rust-lang/trait-system-refactor-initiative#269
I am not sure that the check is placed into the right place in the code.
r? lcnr