Add back tests/rustdoc-gui/notable-trait.goml test - #161409
Open
GuillaumeGomez wants to merge 1 commit into
Open
Add back tests/rustdoc-gui/notable-trait.goml test#161409GuillaumeGomez wants to merge 1 commit into
tests/rustdoc-gui/notable-trait.goml test#161409GuillaumeGomez wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Member
|
As with the others, I gonna trust that you did due diligence. @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 20, 2026
Add back `tests/rustdoc-gui/notable-trait.goml` test Part of rust-lang#152197. Mostly the same test, I just replaced the flaky `assert-position` with a `wait-for-position`. r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 20, 2026
Add back `tests/rustdoc-gui/notable-trait.goml` test Part of rust-lang#152197. Mostly the same test, I just replaced the flaky `assert-position` with a `wait-for-position`. r? @Urgau
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 20, 2026
…uwer Rollup of 20 pull requests Successful merges: - #152617 (std: implement `sleep_until` for Fuchsia) - #158934 (diagnostics: fix `let x: vec![]` suggestion pointing into stdlib) - #161277 (bootstrap: Move all non-module items out of the crate root) - #161295 (std: don't panic on long-elapsed deadlines for `sleep_until`) - #161368 (Double-word align `_Unwind_Exception`) - #161370 (Uplift rustfmt macro formatting fix) - #161378 (`FlowSensitiveAnalysis` cleanups) - #158032 (Offload expose device selection) - #158855 (Add `desktop` method to `CommandExt`) - #161199 (Add regression test for non lifetime binders) - #161302 (Add regression test for inconsistent import resolution from issue 147208) - #161329 (Add regression tests for a few fixed issues with E-needs-test) - #161330 (Add regression test for nested RPIT not an iterator ICE) - #161351 (Cleanup: Move impl of `#[rustc_dump_object_lifetime_defaults]`) - #161355 (Add file path to some archive build errors) - #161373 (Allow running EC2 jobs locally) - #161393 (Configure LLM policy URL for triagebot) - #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test) - #161410 (Fix rustdoc remapping `documentation` scope documentation) - #161415 (Update expect messages in path docs to better follow guidelines)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
Add back `tests/rustdoc-gui/notable-trait.goml` test Part of rust-lang#152197. Mostly the same test, I just replaced the flaky `assert-position` with a `wait-for-position`. r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
Add back `tests/rustdoc-gui/notable-trait.goml` test Part of rust-lang#152197. Mostly the same test, I just replaced the flaky `assert-position` with a `wait-for-position`. r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 21, 2026
Add back `tests/rustdoc-gui/notable-trait.goml` test Part of rust-lang#152197. Mostly the same test, I just replaced the flaky `assert-position` with a `wait-for-position`. r? @Urgau
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 21, 2026
…uwer Rollup of 16 pull requests Successful merges: - #161259 (move some attribute related structs out of rustc_attr_ir) - #160853 (delegation: simplify matches on `FnKind`, minor refactorings) - #159899 ( `GenericArgs::types` triage + possible fixes) - #160459 (Use attribute parser for `deprecated` attribute checking) - #160813 (Optimize linked list iterator performance) - #161271 (doc: document safety requirements for core WTF-8) - #161317 (LLVM 24: configure float-abi via module flag) - #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow) - #161369 (Add regression test for confusing lifetime error message issue) - #161393 (Configure LLM policy URL for triagebot) - #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB) - #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test) - #161410 (Fix rustdoc remapping `documentation` scope documentation) - #161415 (Update expect messages in path docs to better follow guidelines) - #161438 (Change triagebot backport to ping T-libs-fcp) - #161442 (Add regression test for dead code on type alias used in impl self type) Failed merges: - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 21, 2026
Add back `tests/rustdoc-gui/notable-trait.goml` test Part of rust-lang#152197. Mostly the same test, I just replaced the flaky `assert-position` with a `wait-for-position`. r? @Urgau
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #152197.
Mostly the same test, I just replaced the flaky
assert-positionwith await-for-position.r? @Urgau