Repository navigation
test(ui-react): capture destination motion before activation returns - #1975
Closed
schlessera wants to merge 1 commit into
Closed
schlessera wants to merge 1 commit into
schlessera wants to merge 1 commit into
Conversation
schlessera
force-pushed
the
test/1915-capture-opening-motion-3d746bc3-c
branch
from
October 15, 2026 10:39
34398cd to
eefe920
Compare
This was referenced Oct 15, 2026
schlessera
marked this pull request as draft
October 15, 2026 11:07
This was referenced Oct 15, 2026
Owner
Author
|
Superseded by merged #1979, squash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1915
What changed
The destination paint proof captures and pauses the real CSS animations in a DOM insertion observer armed before native activation. Sampling after the asynchronous click returns uses those retained objects, so completed fill-none openings cannot disappear before the 0/150/300ms paint checks. All existing animation, paint, pointer/theme/width, safe-area, hit-target and keyboard assertions remain.
Why this shape
The source-bound CPU-quota reproduction shows both native opening animations ending before the click returned. A fixture-local observer captures them in the insertion microtask. No product animation, duration, timeout, guard or browser configuration changes ship in this PR.
The runtime regression plays the actual captured openings to native completion, verifies their disappearance from the live animation set, and proves the retained objects can still be sought for paint proof. It follows the two named opening effects separately from loading animations.
Proof
Current candidate
eefe9203fdb5c8e71582cba082371a89efb5cbaa, parentfb219e069a8afd7fbc5eac6524b7a77ec08a7560:bun run check:pr --base origin/main: 54 tests / 181 assertions pass, including the metadata/leakage/lint preflight.bun run typecheck: strict types pass.Runtime controls used the d2b4cf9 base plus the test change, before refreshing over #1954's unrelated draft tests and wait documentation; the browser inputs are unchanged by that refresh:
opening references survive a sample after native completionassertion, after the native opening effects leave the live set. Mutation restored.Initial ready run 38718847475, attempt 1, passes every selected job and aggregate at head
34398cd4f73ea33b7d2430d02d935fad51bcf24a. All 13 selected checkout logs agree onb284d317d6806db7e73565e241f4d9e7f94230c8, parents5c453d865d55993c86861da3f428d324405bf506/34398cd4f73ea33b7d2430d02d935fad51bcf24a, tree0ecf0a9fb0134d881b9b250953b2e7603bce1dd1; API and local Git agree. Browser shards pass 4580 / four existing exclusions and 4228 / six existing exclusions, including the new regression in all three projects. Pack is planner-intentionally unselected. Head-only contract run 38718853060 separately passes at 34398cd.Main advanced with #1899's share-review UI, Settings passkey tab and browser-project changes. Those affect fixture inputs, so the old run was allowed to finish fully, then the candidate was refreshed. The changed browser test is byte-identical across that refresh; rebuild, preflight, types and focused matrix pass at the new source. Refreshed ready run 38721875723, attempt 1, is failed, with a separate native PDF page-creation failure tracked in #1978. All 13 selected checkout logs agree on
cb221fba3385ec6099145e792629e93bf03a0fef, parentsfb219e069a8afd7fbc5eac6524b7a77ec08a7560/eefe9203fdb5c8e71582cba082371a89efb5cbaa, tree454c743cf990dc6a0a68c357c6f6f77eb1da2ad6; API, Git and the failed shard artifact agree. Both browser shards pass (4580 / four existing exclusions and 4228 / six existing exclusions), including all three new regression instances. Both layouts, runtime, captures, verify and unit shards 1/2/4 pass. Unit shard 3 fails (891 pass / one fail / 13584 assertions); the aggregate fails. Packaging is intentionally unselected. Head-only contract run 38721938525 separately passes eefe920.The failure is
TargetCloseError: Protocol error (Target.createTarget): Target closedfrom actual PuppeteernewPagein the final finished-PDF link case, before PDF assertions. Its renderer/test source is unchanged, and the browser test edited here is excluded from that native unit inventory. Close/disconnect cause is unknown. No failed job was rerun or gate weakened; the completed failed run was retained before converting this PR to draft. The earlier qualification is not relabelled as proof for the new combined tree.Checklist
Anything left open
Blocked by #1978. Keep this PR draft and #1915 open until the native PDF browser-connection failure has a diagnosed causal control and scoped repair. Then inspect current main, refresh only for relevant changes and complete selected current-candidate hosted proof before merge. Preserve every original #1915 acceptance criterion and its source-bound red/mutation receipts. This correction is unmerged and qualification remains incomplete.