Repository navigation
test(home): match candidates path with native separator - #464
Closed
chloe41427[bot] wants to merge 1 commit into
Closed
chloe41427[bot] wants to merge 1 commit into
chloe41427[bot] wants to merge 1 commit into
Conversation
![Chloe41427[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Signed-off-by: Chloe41427[bot] <chloe@sdkman.io>
3 of 4 tasks
Contributor
Author
|
Superseded by #465: Windows binaries should print forward slashes, not adapt the tests to backslashes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Windows CI failure in run 40045254057.
tests/home.rshardcoded forward slashes in the expected stdout forshould_successfully_display_current_candidate_homeandshould_keep_value_plain_under_clicolor_force. On Windows,homeprints the path viaPathBuf::display(), which uses\, so the assertions failed there (same root cause already fixed fortests/helpers.rsin a390df9).Builds the expected path with
Path::joininstead, matching the native separator.