Repository navigation
fix: render paths with forward slashes on windows - #465
Merged
Merged
Conversation
Signed-off-by: Chloe41427[bot] <chloe@sdkman.io>
marc0der
approved these changes
Oct 24, 2026
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows binaries must print paths with forward slashes, as on Unix. SDKMAN runs on Windows under a Unix-like shell, so backslashes have no place in its output. #461 started rendering paths with
Path::display(), which uses\on Windows. That broke thehomeoutput and the paths in error messages.ui::slashed, which renders a path with/on every platform. It only replaces separators on Windows, because\is a legal filename character on Unix.homeprints its path throughui::slashed.ui::path, used for paths in messages, goes throughui::slashed./again: this reverts the native-separator assertion from a390df9 intests/helpers.rs.tests/home.rsnormalises the tempSDKMAN_DIRit compares against.ui::slashed.Supersedes #464, which changed the tests to accept backslashes.
Test plan
cargo fmt --checkcargo clippy --all-targets -- -D warningscargo test(Linux arm64)pull_request.ymlruns onpull_request_targetand buildsmaster, not this branch, so the push build onmasterafter the merge is the Windows verification.