Revert "Refactor v2: faster pop/reserve/retain_mut, modern Criterion benches, Miri-friendly tests + fmt in CI" - #430
Merged
Conversation
…benches,…" This reverts commit 36f34e1.
Contributor
Author
|
this should be urgently merged |
jdm
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #396
due to failed CI checks
issue:
clap_lexrequires rust edition 2024, but we are working with 2021errors when testing 1.83 version
we are reverting to the latest known-good version
long version
#396 depends on
criterion = "0.8", which has a MSRV of 1.86, but the MSRV in our toolchain is 1.83we will revert #396, bring back the PR and make the necessary changes by downgrading to
criterion = "0.7"that only needs rust 1.80+