Repository navigation
fix(ops): pin DuckDB 1.5.5 and attach the selected span catalog by literal - #849
Merged
Merged
Conversation
…teral `pnpm db --preview` failed before any query: DuckDB takes an ATTACH path only as a literal, so `ATTACH getvariable(...)` was a parser error. Behind it, the iceberg extension reads the catalog from ENDPOINT, not URI, and DuckDB 1.5.2's iceberg extension aborts reading R2 span manifests (DATE -> INTEGER, duckdb-iceberg#941, fixed in 1.5.3). mise.toml pins DuckDB 1.5.5. The init file keeps the extension, secret and production usage history; the launcher attaches only the selected span catalog as `telemetry` with a literal warehouse, then reads the unchanged views from duckdb-views.sql. Each step runs in DuckDB's own shell before the user's arguments, so pnpm db still execs DuckDB for the terminal and fails on the first error. A real-DuckDB test drives each environment's command against a local Iceberg REST catalog on the pinned release. It fails on the previous init with the same parser error.
anandpant
marked this pull request as ready for review
November 16, 2026 23:42
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm db --previewfailed before running any query, so the PR 848 telemetry proof could not read retained rows. There were three causes:ATTACHpath only as a literal, soATTACH getvariable(...)induckdb-init.sqlis a parser error. This holds on both 1.5.2 and 1.5.5.ENDPOINT. It doesn't useURI.DATE -> INTEGER). This is duckdb-iceberg#941, fixed in 1.5.3.Change
mise.tomlpinsduckdb = "1.5.5".duckdb-init.sqlkeeps the extension, the token secret and the production usage history attach (codemode_history), now with a literal warehouse andENDPOINT.pnpm dbattaches only the selected span catalog astelemetry, using a literal warehouse, and then reads the views. The views moved unchanged toduckdb-views.sql. Each step runs as a DuckDB-cmdbefore the user's arguments. DuckDB still replaces the process, so it owns the terminal and Ctrl-C, and the first error exits 1.Proof
URI, and running DuckDB 1.5.2.pnpm ci:local --no-signoffagainstorigin/mainpassed in 3m20s.pnpm ci:localon the pushed head63411b50passed in 7s, reusing the native task cache, and postedlocal-cisuccess.Limits
No live
pnpm dbrun on 1.5.5 against R2 is part of this PR. A separate read of the selected preview catalog on 1.5.5, using a literal attach and the unchanged views, exited 0 with no matching rows. That read did not includeINSTALLor the history attach.Review
An independent Sol review (t3sj) accepted
63411b50with no actionable findings in the change.