Repository navigation
refactor(scenarios): move diagram-scenarios to tools/scenarios - #851
Merged
Merged
Conversation
Move packages/diagram/scenarios to tools/scenarios. The Nx name diagram-scenarios, package name, tags and Vite-bundled CLI are unchanged; the runnable CLI is now tools/scenarios/dist/cli.js, with no old-path shim. Update every local consumer path (root and tools TypeScript config, Studio and editor Vite/Vitest/Storybook aliases and references, the native conversion Storybook) and the lockfile importer. The built CLI's --list output and all 118 --fixture reports, plus passing and failing --input replays, are byte-identical to the base build. Record the move in the plan and add Fable's Studio checklist note: the 60s chat idle bound is proven only by stubbed stalls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move diagram-scenarios to tools/scenarios
packages/diagram/scenariosis nowtools/scenarios. The scenario runner is a tool, as the plan says. Frontierclimb calls it for case discovery and deterministic grading, so a paired Frontierclimb PR moves that caller: shpitdev/frontierclimb#281 (head83ec4eb3e3e3f497efe62fd9d787dcaa22087d99, left unmerged).Changes
git mvof the whole project;packages/diagram/is gone. The Nx namediagram-scenarios, the package@sketchi/diagram-scenarios, the tagsscope:package,type:eval(Studio and the editor import it) and the Vite-bundled CLI are unchanged. The CLI is nowtools/scenarios/dist/cli.js, with no shim at the old path.ssr/outDir, and the Vitest cache, aliases and coverage.tsconfig.json;tools/{tsconfig.json,vitest.config.mts}; the native-conversion Storybook; editor tsconfig, Vitest and Storybook; Studio tsconfig, Vite and both Vitest configs. The lockfile change is importer paths only.nx sync:checkis clean.project.jsonshows as a rename at-M30%; only its paths changed.Proof, base
a70feeb9vse384a562Built CLI identity: base build from a clean export of
a70feeb9, same mise toolchain. Byte-identical:--list(118 cases);--fixturereports, all exit 0, 78 witheditDrags>0and none witheditUnavailable;--inputreplays ofincident-escalationandcheckout-payment-sequence;The bundled
cli.jsdiffers only in 25 bundler// <module path>comments.Actual Frontierclimb adapters from the paired branch, run with
SKETCHI_REPOpointing at this worktree ate384a562(clean, mise node 26.13.0 / pnpm 12.16.1):preparepasses forsketchiandsketchi-generate. The CLI resolves undertools/scenarios. The runtime closure istools/scenariospluspackages/{cloudflare,diagrams,drawing,icons/catalog,observability}dist.casesis byte-identical to the base--list; generate and no-cue cases return 118 each.check, MCP, generate and no-cue, passing and failing: grades are correct, failed checks becomeok:false, and each reports 12 bound routes and 12 editor drags with noeditUnavailable.These runs are offline: no samples, models or services.
Focused checks:
diagram-scenariosbuild, typecheck, test (126 passing) and check-scenario; playground/editor typecheck; editor tests; Studioapi.server.test.ts;opscheck-tools, lint, format and references; native-conversion and editor Storybook builds.Independent review: Sol (t3tt) accepted
e384a562with no actionable findings. It confirmed identical blob IDs for all 53 relocated source files and correct relative depths everywhere. It ran its own plain-Node checks of the built CLI with editor drags, and found all 122 saved old/new JSON pairs byte-identical (.memory/effect-execution/phase3/scenarios-sketchi-review.md).Full gate:
pnpm ci:local --no-signoffagainstorigin/maina70feeb9passes one384a562in 2m39s, sampled routing included. The first attempt failed onlyops:check-workflows, because actionlint (installed by my-nix at~/go/bin) was not on the agent shell's PATH. The rerun on the unchanged head added it.Pushed-head signoff:
pnpm ci:localon the pushede384a562passed and postedlocal-cisuccess on this PR.Not in this PR
Production and previews are not deployed. The paired Frontierclimb PR stays on a merge hold that only the user lifts, even after this PR merges.