fix(ci): scope the CLI telemetry token to the build and publish steps - #7969
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SIM_CLI_TELEMETRY_KEYat job level, so theRun testsstep inherited it.install.process.test.tsruns the real CLI (sim update) in a child process that inherits the environment, and the CLI reads the token at runtime, so every publish run sent fakecli_command_executedevents (update, version2.1.2, the test fixture's version) to production usage dataBuild packageandPublish to npm(whoseprepublishOnlyrebuild is what ships). Every other step, tests included, runs without itType of Change
Testing
updateevents per run; without it, nonedist, no runtime env reads,sim telemetry statusreports on; the smoke step (--version, no token) sends nothing; a rebuild without the token reports off, so publish still needs itactionlint, sim-cli suite without the token (10 consecutive runs), lint,check:auditsChecklist