Skip to content

fix(ci): scope the CLI telemetry token to the build and publish steps #7969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Sep 18, 2026
Merged

fix(ci): scope the CLI telemetry token to the build and publish steps #7969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions .github/workflows/publish-sim-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@ concurrency:

jobs:
publish-npm:
# Job-level, not on the build step: `bun publish` runs `prepublishOnly`,
# which rebuilds `dist` a second time, and that second build is the one
# that ships. A build without the token reports nothing. See
# docs/cli/usage-data.
env:
SIM_CLI_TELEMETRY_KEY: ${{ vars.SIM_CLI_TELEMETRY_KEY }}
SIM_CLI_TELEMETRY_HOST: ${{ vars.SIM_CLI_TELEMETRY_HOST }}
runs-on: ${{ (vars.CI_PROVIDER == '' || vars.CI_PROVIDER == 'blacksmith') && 'blacksmith-4vcpu-ubuntu-2404' || 'ubuntu-latest' }}
timeout-minutes: 15
steps:
Expand Down Expand Up @@ -73,8 +66,15 @@ jobs:
working-directory: packages/sim-cli
run: bun run type-check

# The usage-reporting destination is baked into the bundle at build time
# (docs/cli/usage-data), so only the two steps that build it get the
# token. Every other step, the tests above in particular, runs without
# it: a test that runs a real command must never report to production.
- name: Build package
working-directory: packages/sim-cli
env:
SIM_CLI_TELEMETRY_KEY: ${{ vars.SIM_CLI_TELEMETRY_KEY }}
SIM_CLI_TELEMETRY_HOST: ${{ vars.SIM_CLI_TELEMETRY_HOST }}
run: bun run build

- name: Resolve release channel
Expand Down Expand Up @@ -140,11 +140,15 @@ jobs:
exit 1
fi

# `bun publish` runs `prepublishOnly`, which rebuilds `dist`, and that
# rebuild is what ships, so it needs the token as well.
- name: Publish to npm
working-directory: packages/sim-cli
env:
NPM_CONFIG_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_TAG: ${{ steps.release.outputs.tag }}
SIM_CLI_TELEMETRY_KEY: ${{ vars.SIM_CLI_TELEMETRY_KEY }}
SIM_CLI_TELEMETRY_HOST: ${{ vars.SIM_CLI_TELEMETRY_HOST }}
run: bun publish --access public --tag "$NPM_TAG" --no-save

- name: Summarize release
Expand Down
Loading