refactor(emcn): share filled stop icon across chat controls - #7977
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public chat, organization chat, and workspace chat each implemented the same filled stop icon inline. Add one
StopFilledicon to EMCN and use it at all three call sites, preserving the original SVG geometry, caller classes, accessible button names, and stop handlers.Follows #7975. That PR merged before this branch was prepared, so this branch starts at its merge commit and targets
stagingdirectly. The product changes are the shared icon, its barrel export, and the three consumer updates.CI also exposed an existing race in the desktop terminal-selection test: its fixture read the buffer after a fixed 30 ms delay, before xterm necessarily finished parsing. Replace the delay with the completion callback of a trailing empty write. The fixture now waits for all preceding writes without changing its assertions or desktop runtime code.
Validation:
StopFilledrecreates the original SVG and all non-import component syntax at all three call sites, including size, light/dark fill classes, conditions, and handlers.git diff --checkpass.The landing-page demo retains its copy under the existing landing exclusion. The external linter, verification scripts, reports, and dependency installation are not part of this PR.