Skip to content

refactor(emcn): share filled stop icon across chat controls - #7977

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/control-fix-shared-stop-icon
Sep 18, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/control-fix-shared-stop-icon

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Public chat, organization chat, and workspace chat each implemented the same filled stop icon inline. Add one StopFilled icon to EMCN and use it at all three call sites, preserving the original SVG geometry, caller classes, accessible button names, and stop handlers.

Follows #7975. That PR merged before this branch was prepared, so this branch starts at its merge commit and targets staging directly. The product changes are the shared icon, its barrel export, and the three consumer updates.

CI also exposed an existing race in the desktop terminal-selection test: its fixture read the buffer after a fixed 30 ms delay, before xterm necessarily finished parsing. Replace the delay with the completion callback of a trailing empty write. The fixture now waits for all preceding writes without changing its assertions or desktop runtime code.

Validation:

  • Full external category audit: duplicate-artwork findings reduced from 3 to 0; no missing-button-name findings remain.
  • Final committed-diff linter: zero introduced usage violations. Its two expected system-change notices identify the new central icon and barrel export; source equivalence was checked for both. The new icon's generic SVG props spread produces the same control-presence uncertainty as other reusable icons; all three consumers pass only their existing classes.
  • Source equivalence check: expanding StopFilled recreates the original SVG and all non-import component syntax at all three call sites, including size, light/dark fill classes, conditions, and handlers.
  • All 36 existing composer, user-input, and chat-streaming tests pass.
  • All 1,657 desktop tests across 71 files pass after the CI test correction; desktop type checking and the changed test's Biome check pass.
  • App and EMCN type checks, scoped Biome checks, API validation, and git diff --check pass.

The landing-page demo retains its copy under the existing landing exclusion. The external linter, verification scripts, reports, and dependency installation are not part of this PR.

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 18, 2026 7:28pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable regressions identified.

Summary

The PR centralizes the duplicated filled stop SVG as an EMCN icon while preserving the existing controls.

  • Adds and exports the reusable StopFilled icon.
  • Replaces three equivalent inline SVGs without changing button labels, handlers, conditions, dimensions, or colors.
  • Consolidates the workspace send-button icon imports through the supported icons entry point.

Reviews (1) · Last reviewed commit: "refactor(emcn): share filled stop icon a..."

@waleedlatif1
waleedlatif1 merged commit 59a5edf into staging Sep 18, 2026
35 of 36 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-shared-stop-icon branch September 18, 2026 19:33

This branch was previously deployed

1 inactive deployment
Preview 09670d4c Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants