You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Resource, knowledge-document and table-cell selection bars supplied the same bulk-action appearance through application class strings. Add EMCN's BulkActionButton, built on the existing Button, and migrate all six authored button locations across the three implementations. EMCN now owns the 28px geometry, radius, zero padding and brand hover treatment; the application styling helper is removed.
The default surface='adaptive' preserves the resource/knowledge light and dark chip backgrounds. surface='uniform' preserves the table buttons' existing surface-5 background in both themes. The component requires an accessible label and forwards native button props and refs. Icons, labels, handlers, disabled conditions, tooltips, the Move menu trigger, native form behavior, selection/permission logic and animations are preserved.
Validation:
Exact before/after class comparison at all six locations and normalized consumer AST comparison confirm unchanged styling and surrounding behavior code. DOM compatibility tests cover the default and both explicit surfaces; focused tests cover refs, events, focus, disabled actions, default/non-submitting form behavior and actual tooltip/menu-trigger composition. The surface checks run once each, with disabled behavior covered separately. No screenshot comparison was performed.
330 EMCN tests (including 9 focused component tests), 71 related app tests, EMCN/app type checks, repository lint, API validation and diff whitespace checks pass.
The external category check now requires actual EMCN ownership: six application-owned locations become six central consumers, with zero remaining category findings, copied patterns, unresolved candidates or consumer appearance overrides. Its 13 regression tests and type checks pass. Existing limits remain explicit, including two oversized generated sources and unresolved class inputs elsewhere.
The final committed PR-diff audit completes with zero violations and zero introduced findings in the three earlier simplification categories. It reports ten intentional central-definition changes for the new recipe: default surface, dimensions, padding, radius and existing background/hover colors. These migrate established styling into EMCN; the class-equivalence checks cover all six consumers.
Generic audit counts change because six Button consumers now use BulkActionButton. The dedicated category check validates their central ownership, labels, surface choices and appearance overrides; the generic scanner still cannot fully resolve the new component's dynamic props/class forwarding. No global conformance claim is made.
The cumulative PR contains only three consumer updates, the EMCN component, its export and its component tests. All linter code, checker tests, configuration and audit artifacts remain outside the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resource, knowledge-document and table-cell selection bars supplied the same bulk-action appearance through application class strings. Add EMCN's
BulkActionButton, built on the existingButton, and migrate all six authored button locations across the three implementations. EMCN now owns the 28px geometry, radius, zero padding and brand hover treatment; the application styling helper is removed.The default
surface='adaptive'preserves the resource/knowledge light and dark chip backgrounds.surface='uniform'preserves the table buttons' existing surface-5 background in both themes. The component requires an accessible label and forwards native button props and refs. Icons, labels, handlers, disabled conditions, tooltips, the Move menu trigger, native form behavior, selection/permission logic and animations are preserved.Validation:
The cumulative PR contains only three consumer updates, the EMCN component, its export and its component tests. All linter code, checker tests, configuration and audit artifacts remain outside the PR.