Skip to content

refactor(ui): centralize circular composer action buttons in EMCN - #7983

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-composer-action-buttons
Sep 18, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/control-fix-composer-action-buttons

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

Seven send, stop and search button locations repeat the same circular appearance across workspace home, organization home/search and workflow chat. Add EMCN ComposerActionButton on the existing Button, migrate all seven locations and remove the application styling constants.

The component owns the existing 28px/default and 22px/compact treatments. It preserves their respective hover rules, light/dark colors and zero padding. active controls appearance independently of native disabled, so a populated workflow-chat composer can remain visually active while execution prevents submission. Consumers retain the original icons, labels, handlers, disabled conditions, form types and layout.

This is an independent PR against staging, starting after #7982 merged. The nine-file diff contains only the component, public exports, consumer changes and tests. Linter tooling and reports remain external.

Type of Change

  • Other: behavior-preserving UI consolidation

Testing

  • 343 EMCN tests passed, including seven focused compatibility/interaction cases for the new component.
  • 23 existing app tests passed across organization composer, organization search and workflow chat.
  • EMCN and app type checks, repository lint and API-validation audit passed.
  • External source comparison verified unchanged consumer syntax outside the migration, including active predicates, handlers, disabled conditions, labels and icon children. All 11 existing appearance states across seven locations retain their merged class sets; the workspace h-[28px] w-[28px]size-[28px] shorthand has identical compiled declarations.
  • Final category check: 7 central uses, 0 findings, 0 unresolved direct candidates, 0 copied palette patterns. The unchanged SendButton wrapper is reported separately; its two authored branches are included in the seven checked uses.
  • Final immutable PR audit: 0 violations, 17 intentional central-definition notifications. These cover moving the existing geometry, default size, padding, border and active/inactive light/dark/hover fills into EMCN. The existing exact colors are deliberately retained in the central component rather than substituted with different theme values.

Validation uses source, compiled CSS declarations and DOM/interaction tests; no live browser screenshot comparison was performed. The broader audit still has unrelated findings and analysis gaps, including two oversized generated tool sources outside this category's completed inspection.

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the consolidation preserves the migrated controls’ behavior and effective presentation.

Summary

This PR centralizes the repeated circular composer action-button presentation in a new EMCN component.

  • Adds ComposerActionButton with default and compact geometry plus active and inactive presentation.
  • Migrates organization composer/search, workspace home, and workflow-chat send and stop controls.
  • Removes the duplicated application styling constants.
  • Adds component compatibility, event-forwarding, disabled-state, ref, and native form-behavior coverage.

Reviews (1) · Last reviewed commit: "refactor(emcn): centralize composer acti..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 18, 2026 9:56pm UTC

Request Review

@waleedlatif1
waleedlatif1 merged commit 80adb13 into staging Sep 18, 2026
36 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-composer-action-buttons branch September 18, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants