refactor(ui): centralize circular composer action buttons in EMCN - #7983
Merged
Merged
Conversation
Contributor
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seven send, stop and search button locations repeat the same circular appearance across workspace home, organization home/search and workflow chat. Add EMCN
ComposerActionButtonon the existingButton, migrate all seven locations and remove the application styling constants.The component owns the existing 28px/default and 22px/compact treatments. It preserves their respective hover rules, light/dark colors and zero padding.
activecontrols appearance independently of nativedisabled, so a populated workflow-chat composer can remain visually active while execution prevents submission. Consumers retain the original icons, labels, handlers, disabled conditions, form types and layout.This is an independent PR against staging, starting after #7982 merged. The nine-file diff contains only the component, public exports, consumer changes and tests. Linter tooling and reports remain external.
Type of Change
Testing
h-[28px] w-[28px]→size-[28px]shorthand has identical compiled declarations.SendButtonwrapper is reported separately; its two authored branches are included in the seven checked uses.Validation uses source, compiled CSS declarations and DOM/interaction tests; no live browser screenshot comparison was performed. The broader audit still has unrelated findings and analysis gaps, including two oversized generated tool sources outside this category's completed inspection.