improvement(ui): share canvas toolbar controls by BillLeoutsakosvl346 · Pull Request #8066 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-20T22:48:06Z

Summary

Share the four canvas navigation actions through a local EMCN Button composition.
Preserve active/ghost colors, 28px geometry, disabled states, tooltips and command handlers.

Type of Change

Refactor / maintainability improvement

Testing

Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
External source comparison confirms caller logic and content are unchanged.
Original and extracted components have matching computed styles in light/dark browser fixtures; keyboard, disabled and expansion behavior checked. These are isolated fixtures, not full authenticated product flows.
Relevant existing tests pass. No landing-page changes or audit tooling included.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-20T22:48:10Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 24, 2026 10:57pm UTC

greptile-apps · 2026-09-20T22:50:35Z

Confidence Score: 5/5

The PR appears safe to merge because no outstanding behavioral regressions or repository-rule violations remain.

Summary

This PR extracts the canvas toolbar’s common square actions into CanvasControlButton and adds a reusable EMCN ghost-hover variant while preserving existing sizing, colors, disabled behavior, tooltips, and handlers.

Shares the active and inactive canvas action styling through one local component.
Replaces repeated 28px button configuration with the supported iconSize='regular' composition.
Keeps the hover-surface class self-contained within the EMCN Button variant.
All previous review findings are resolved in the current code.

_{Reviews (9) · Last reviewed commit: "refactor(emcn): keep Button hover varian..."}

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-20T22:57:21Z

@greptile

BillLeoutsakosvl346 · 2026-09-20T22:57:22Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-20T22:57:28Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-20T23:03:23Z

@greptile

BillLeoutsakosvl346 · 2026-09-20T23:03:24Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-20T23:03:30Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-21T17:57:21Z

Before / after visual comparison

Canvas actions share CanvasControlButton. Quiet, active and disabled appearances are shown.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: 97f93396c1.

BillLeoutsakosvl346 · 2026-09-22T19:59:12Z

@greptile

BillLeoutsakosvl346 · 2026-09-22T19:59:13Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T19:59:19Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T22:20:42Z

@greptile

BillLeoutsakosvl346 · 2026-09-24T22:20:47Z

@cubic-dev-ai review this PR

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

BillLeoutsakosvl346 · 2026-09-24T22:25:08Z

@greptile

BillLeoutsakosvl346 · 2026-09-24T22:25:11Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T22:25:16Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 2 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T22:36:39Z

@greptile

BillLeoutsakosvl346 · 2026-09-24T22:36:45Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T22:36:50Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 3 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T22:49:10Z

@greptile

BillLeoutsakosvl346 · 2026-09-24T22:49:14Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T22:49:20Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 3 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T22:55:26Z

@greptile

BillLeoutsakosvl346 · 2026-09-24T22:55:31Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T22:55:37Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 3 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

vercel Bot temporarily deployed to Preview September 20, 2026 22:48 Inactive

cubic-dev-ai Bot reviewed Sep 20, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 20, 2026

View reviewed changes

Comment thread ...orkspace/[workspaceId]/w/[workflowId]/components/workflow-controls/canvas-control-button.tsx Outdated

vercel Bot temporarily deployed to Preview September 20, 2026 22:56 Inactive

greptile-apps Bot reviewed Sep 20, 2026

View reviewed changes

Comment thread ...orkspace/[workspaceId]/w/[workflowId]/components/workflow-controls/canvas-control-button.tsx Outdated

cubic-dev-ai Bot reviewed Sep 20, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview September 20, 2026 23:03 Inactive

cubic-dev-ai Bot reviewed Sep 20, 2026

View reviewed changes

Bill Leoutsakos added 2 commits September 22, 2026 12:20

improvement(emcn): share ordinary action geometry in Button

d583476

improvement(ui): share canvas toolbar controls

42746a1

BillLeoutsakosvl346 changed the base branch from staging to codex/overrides-button-sizing September 22, 2026 19:59

BillLeoutsakosvl346 force-pushed the codex/control-fix-canvas-controls branch from 97f9339 to 42746a1 Compare September 22, 2026 19:59

vercel Bot temporarily deployed to Preview September 22, 2026 19:59 Inactive

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

Base automatically changed from codex/overrides-button-sizing to codex/control-fix-icon-button-sizing September 23, 2026 02:12

Merge icon button sizing base into canvas controls

f1b915b

improvement(ui): reuse Button treatments for canvas actions (#8155)

5a86de2

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

vercel Bot temporarily deployed to Preview September 24, 2026 22:23 Inactive

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread ...orkspace/[workspaceId]/w/[workflowId]/components/workflow-controls/canvas-control-button.tsx Outdated

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread ...orkspace/[workspaceId]/w/[workflowId]/components/workflow-controls/canvas-control-button.tsx Outdated

Comment thread ...orkspace/[workspaceId]/w/[workflowId]/components/workflow-controls/canvas-control-button.tsx

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread ...orkspace/[workspaceId]/w/[workflowId]/components/workflow-controls/canvas-control-button.tsx Outdated

fix(ui): preserve canvas action hover treatment

b0f4bd2

vercel Bot deployed to Preview September 24, 2026 22:37 View deployment

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread ...pp/workspace/[workspaceId]/w/[workflowId]/components/workflow-controls/workflow-controls.tsx

Comment thread packages/emcn/src/components/button/button.tsx Outdated

fix(ui): retain muted canvas icon and import conventions

bac801d

vercel Bot deployed to Preview September 24, 2026 22:50 View deployment

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread ...pp/workspace/[workspaceId]/w/[workflowId]/components/workflow-controls/workflow-controls.tsx

Comment thread packages/emcn/src/components/button/button.tsx Outdated

refactor(emcn): keep Button hover variant self-contained

66c834e

vercel Bot deployed to Preview September 24, 2026 22:57 View deployment

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

BillLeoutsakosvl346 merged commit b182120 into codex/control-fix-icon-button-sizing Sep 24, 2026
8 checks passed

waleedlatif1 deleted the codex/control-fix-canvas-controls branch September 24, 2026 23:57

BillLeoutsakosvl346 mentioned this pull request Sep 25, 2026

refactor(ui): centralize compact icon button sizing in EMCN #7991

Open

Conversation

BillLeoutsakosvl346 commented Sep 20, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 20, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 20, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 20, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 20, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 20, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 20, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Before / after visual comparison

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

vercel Bot commented Sep 20, 2026 •

edited

Loading

greptile-apps Bot commented Sep 20, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading