-
Notifications
You must be signed in to change notification settings - Fork 3.8k
improvement(ui): share canvas toolbar controls #8066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
BillLeoutsakosvl346
merged 7 commits into
codex/control-fix-icon-button-sizing
from
codex/control-fix-canvas-controls
Sep 24, 2026
+37
−36
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d583476
improvement(emcn): share ordinary action geometry in Button
42746a1
improvement(ui): share canvas toolbar controls
f1b915b
Merge icon button sizing base into canvas controls
5a86de2
improvement(ui): reuse Button treatments for canvas actions (#8155)
BillLeoutsakosvl346 b0f4bd2
fix(ui): preserve canvas action hover treatment
bac801d
fix(ui): retain muted canvas icon and import conventions
66c834e
refactor(emcn): keep Button hover variant self-contained
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
21 changes: 21 additions & 0 deletions
21
...space/[workspaceId]/w/[workflowId]/components/workflow-controls/canvas-control-button.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import type { ComponentProps } from 'react' | ||
| import { forwardRef } from 'react' | ||
| import { Button } from '@sim/emcn' | ||
|
|
||
| interface CanvasControlButtonProps | ||
| extends Omit< | ||
| ComponentProps<typeof Button>, | ||
| 'variant' | 'size' | 'iconSize' | 'iconPadding' | 'shape' | 'className' | ||
| > { | ||
| active?: boolean | ||
| 'aria-label': string | ||
| } | ||
|
|
||
| /** Square action in the canvas navigation toolbar. */ | ||
| export const CanvasControlButton = forwardRef<HTMLButtonElement, CanvasControlButtonProps>( | ||
| ({ active = false, ...props }, ref) => ( | ||
| <Button {...props} ref={ref} variant={active ? 'active' : 'ghost-hover'} iconSize='regular' /> | ||
| ) | ||
| ) | ||
|
|
||
| CanvasControlButton.displayName = 'CanvasControlButton' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.