Skip to content

fix(usage): centralize chart palette tokens - #8211

Open
BillLeoutsakosvl346 wants to merge 2 commits into
stagingfrom
codex/product-usage-chart-colours
Open

BillLeoutsakosvl346 wants to merge 2 commits into
stagingfrom
codex/product-usage-chart-colours

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Move organization usage chart palette values into the light and dark global theme, keeping chart series, legends, and tooltip swatches on the existing --usage-* variables.
  • Reuse existing colour tokens where their values match exactly and remove the two local palette class applications. The rendered palette and chart layout stay the same.

Type of Change

  • Bug fix

Testing

  • 10 focused organization usage tests passed; type check, lint, lint check, block registry, docs manifest, and 47 repository audits passed.
  • Full design scan: 890 to 874 findings, removing exactly the 16 chart palette findings with no new findings. The committed diff check reports only the nine intentional global token definitions and no new usage violations.
  • Matching isolated chart screenshots and computed colours in light and dark mode at 16px and 20px root text size; all four screenshot pairs are pixel identical.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 24, 2026 10:25pm UTC

Request Review

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor Author

Visual comparison of the organization usage palette. These isolated fixtures use the real global theme CSS and representative bars, legend dots, and tooltip swatches. All computed colours match, and every before/after PNG pair is pixel identical.

Theme and root size Before After
Light, 16px Before, light, 16px After, light, 16px
Dark, 16px Before, dark, 16px After, dark, 16px
Light, 20px Before, light, 20px After, light, 20px
Dark, 20px Before, dark, 20px After, dark, 20px

Representative code change

The usage-chart palette now comes from globals.css, so bars, legend dots, and tooltip swatches resolve the same theme values from one place. The PR also centralizes active-chat, log-status, and presentation-shadow values.

Before

export const USAGE_PALETTE_CLASS =
  '[--usage-chat:#1f9d63] [--usage-enrichment:#c026d3] [--usage-knowledge:#0e9f9f] [--usage-agent:#6f3dfa] [--usage-other:var(--text-secondary)] dark:[--usage-chat:#2dac72] dark:[--usage-enrichment:#d946ef] dark:[--usage-agent:#8b5cf6] dark:[--usage-other:#8a8a8a]'

After

--usage-chat: #1f9d63;
--usage-enrichment: #c026d3;
--usage-knowledge: #0e9f9f;
--usage-agent: var(--brand-agent);
--usage-other: var(--text-secondary);

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no outstanding findings.

Summary

Centralizes organization usage chart palette variables in the global light and dark themes while preserving the existing --usage-* interface.

  • Replaces component-scoped palette classes with theme-level CSS variables.
  • Reuses existing brand and text tokens where values match.
  • Removes obsolete palette class imports and definitions.

Reviews (2) · Last reviewed commit: "fix(usage): centralize chart palette tok..."

Comment thread apps/sim/app/_styles/globals.css
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

This branch was previously deployed

1 inactive deployment
Preview — 7dfc3179 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant