Skip to content

Temporarily disable output generation#537

Merged
alalazo merged 1 commit into
mainfrom
isc26/temporarily-disable-output-regeneration
Jun 19, 2026
Merged

Temporarily disable output generation#537
alalazo merged 1 commit into
mainfrom
isc26/temporarily-disable-output-regeneration

Conversation

@alalazo

@alalazo alalazo commented Jun 17, 2026

Copy link
Copy Markdown
Member

Output generation is a bit too aggressive, and tends to increase a lot the noise to signal ratio for PRs by pushing commits like:

Here we temporarily disable it.

@alecbcs alecbcs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really like to not disable the output generation here. If we need we can disable the output generation writing to the PR, but I don't want to stop running the generation altogether.

@alecbcs

alecbcs commented Jun 17, 2026

Copy link
Copy Markdown
Member

See #538

@alecbcs alecbcs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm alright disabling the output generation here as long as folks update #543 with their changes to outputs/*.sh scripts to validate that they pass before we merge their PRs.

@alalazo alalazo merged commit c5e7661 into main Jun 19, 2026
5 checks passed
@alalazo alalazo deleted the isc26/temporarily-disable-output-regeneration branch June 19, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants