Temporarily disable pushing the changes output to the PR branch#538
Closed
alecbcs wants to merge 1 commit into
Closed
Temporarily disable pushing the changes output to the PR branch#538alecbcs wants to merge 1 commit into
alecbcs wants to merge 1 commit into
Conversation
Signed-off-by: Alec Scott <alec@llnl.gov>
alalazo
reviewed
Jun 18, 2026
Comment on lines
30
to
41
| - name: Download container from artifact if PR | ||
| if: github.event_name == 'pull_request' && inputs.with_pr_container | ||
| uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 | ||
| with: | ||
| name: tutorial-container | ||
| path: /tmp | ||
|
|
||
| - name: Import container from PR artifact | ||
| if: github.event_name == 'pull_request' && inputs.with_pr_container | ||
| run: | | ||
| docker load --input /tmp/tutorial-container.tar | ||
| docker image ls -a |
Member
There was a problem hiding this comment.
Since we are updating the OS and we have no tag for the buildcache yet, also the container is missing - and it takes a long time to create it with the current machinery (we are talking of hours / days for a single pipeline iteration + working around using a tag).
So we would need to override container generation too. That's what makes #537 preferable to me.
Member
Author
|
Superseded by #543 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily pushing the modified outputs to the PR branch.