Skip to content

docs: torchaudio 2.11.0 does not cap torch - #70

Open
thatsrue wants to merge 1 commit into
mainfrom
fix-torchaudio-pin-comment
Open

thatsrue wants to merge 1 commit into
mainfrom
fix-torchaudio-pin-comment

Conversation

@thatsrue

Copy link
Copy Markdown
Collaborator

What changed

The comments in pyproject.toml and AGENTS.md said torch and torchaudio are an exact pair and that torchaudio 2.11.0 caps torch. They now say torchaudio 2.11.0 runs with torch 2.11 and later. The pip check note in AGENTS.md names torch==2.14.1. No pins change.

Why

PyTorch's torchaudio installation docs say 2.11 is built against PyTorch's stable ABI, so it supports torch 2.11 and all later versions (the compatibility matrix lists "2.11 and above" for torchaudio 2.11.0). torch==2.14.1 next to torchaudio==2.11.0 is a supported pair, and no torch cap or Dependabot ignore is needed.

Closes #55

How you checked it

  • Clean Python 3.14 venv, pip install -e ".[dev]": torch 2.14.1, torchaudio 2.11.0, pip check clean, import torch, torchaudio, silero_vad loads
  • ruff check, ruff format --check, mypy transcript_combobulator: clean
  • pytest -m "not slow": 296 passed, 9 deselected
  • python -m build: sdist and wheel build
  • pip install ".[mac]" (mlx-whisper 0.4.3, mlx 0.32.4): pip check clean next to torch 2.14.1
  • Not run: the slow tests (they load models)
  • A bug fix comes with a test that fails without it: docs and comments only, no behavior change
  • Docs match how it works now
  • No secrets or private information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

torch 2.14.1 pinned next to torchaudio 2.11.0

1 participant