Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The comments in
pyproject.tomlandAGENTS.mdsaid torch and torchaudio are an exact pair and that torchaudio 2.11.0 caps torch. They now say torchaudio 2.11.0 runs with torch 2.11 and later. Thepip checknote inAGENTS.mdnamestorch==2.14.1. No pins change.Why
PyTorch's torchaudio installation docs say 2.11 is built against PyTorch's stable ABI, so it supports torch 2.11 and all later versions (the compatibility matrix lists "2.11 and above" for torchaudio 2.11.0).
torch==2.14.1next totorchaudio==2.11.0is a supported pair, and no torch cap or Dependabot ignore is needed.Closes #55
How you checked it
pip install -e ".[dev]":torch 2.14.1,torchaudio 2.11.0,pip checkclean,import torch, torchaudio, silero_vadloadsruff check,ruff format --check,mypy transcript_combobulator: cleanpytest -m "not slow": 296 passed, 9 deselectedpython -m build: sdist and wheel buildpip install ".[mac]"(mlx-whisper 0.4.3, mlx 0.32.4):pip checkclean next to torch 2.14.1slowtests (they load models)