Repository navigation
bump electron to 43 - #136
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Bumps the Electron (and corresponding Electron-provided headers) version used to build the crash-handler native module, and updates CI to use a newer Node.js runtime for the build tooling.
Changes:
- Updated the default Electron/iojs headers version used by the CMake-based native module build.
- Updated GitHub Actions CI environment to target Electron
v43.2.0. - Updated GitHub Actions CI Node.js version to
22.12.0for dependency install/build steps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crash-handler-module/CMakeLists.txt | Bumps the default headers/version used by the module build to align with Electron 43. |
| .github/workflows/build.yml | Updates CI to build against Electron 43 and run build tooling under Node 22. |
Suppressed comments (1)
.github/workflows/build.yml:198
- Same as earlier in this workflow: consider bumping
actions/setup-node@v3toactions/setup-node@v4alongside the Node 22.12.0 pin to avoid relying on an older major of the action.
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: '22.12.0'
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
4
to
+6
| SET(NODEJS_URL "https://artifacts.electronjs.org/headers/dist" CACHE STRING "Node.JS URL") | ||
| SET(NODEJS_NAME "iojs" CACHE STRING "Node.JS Name") | ||
| SET(NODEJS_VERSION "v29.4.3" CACHE STRING "Node.JS Version") | ||
| SET(NODEJS_VERSION "v43.2.0" CACHE STRING "Node.JS Version") |
summeroff
approved these changes
Aug 25, 2026
aleksandr-voitenko
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.