Skip to content

bump electron to 43 - #136

Merged
sandboxcoder merged 3 commits into
streamlabsfrom
rno/upgrade-electron43
Aug 25, 2026
Merged

sandboxcoder merged 3 commits into
streamlabsfrom
rno/upgrade-electron43

Conversation

@sandboxcoder

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the Electron (and corresponding Electron-provided headers) version used to build the crash-handler native module, and updates CI to use a newer Node.js runtime for the build tooling.

Changes:

  • Updated the default Electron/iojs headers version used by the CMake-based native module build.
  • Updated GitHub Actions CI environment to target Electron v43.2.0.
  • Updated GitHub Actions CI Node.js version to 22.12.0 for dependency install/build steps.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
crash-handler-module/CMakeLists.txt Bumps the default headers/version used by the module build to align with Electron 43.
.github/workflows/build.yml Updates CI to build against Electron 43 and run build tooling under Node 22.
Suppressed comments (1)

.github/workflows/build.yml:198

  • Same as earlier in this workflow: consider bumping actions/setup-node@v3 to actions/setup-node@v4 alongside the Node 22.12.0 pin to avoid relying on an older major of the action.
      - name: Install Node.js
        uses: actions/setup-node@v3
        with:
          node-version: '22.12.0'

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 4 to +6
SET(NODEJS_URL "https://artifacts.electronjs.org/headers/dist" CACHE STRING "Node.JS URL")
SET(NODEJS_NAME "iojs" CACHE STRING "Node.JS Name")
SET(NODEJS_VERSION "v29.4.3" CACHE STRING "Node.JS Version")
SET(NODEJS_VERSION "v43.2.0" CACHE STRING "Node.JS Version")
Comment thread .github/workflows/build.yml Outdated
@sandboxcoder
sandboxcoder merged commit c156c31 into streamlabs Aug 25, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants