Skip to content

bump electron to 43 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandboxcoder merged 3 commits into from
Aug 25, 2026
Merged

bump electron to 43 #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
790a4dc
bump electron to 43
sandboxcoder Aug 25, 2026
4c62dcc
use node 24 / electron 43
sandboxcoder Aug 25, 2026
9660c90
pin windows-2022 to find Visual Studio on CI
sandboxcoder Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ env:
BUILD_DIRECTORY: "build"
DISTRIBUTE_DIRECTORY: "distribute"
RELEASE_BUCKET: "slobs-crash-handler"
ELECTRON_VERSION: "v29.4.3"
ELECTRON_VERSION: "v43.2.0"
BIN_DEPENDENCIES: "dependencies2019.0"
AWS_SDK_VERSION: "1.11.704"
AWS_SDK_PATH: "aws-sdk/awsi"
Expand All @@ -30,17 +30,17 @@ permissions:
jobs:
build:
name: 'Build a package'
runs-on: windows-latest
runs-on: windows-2022
steps:
- uses: actions/checkout@v3
- name: Get the version
id: get_version
run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_OUTPUT
shell: bash
- name: Install Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: '16.x'
node-version: '24.x'
- name: Install dependencies
run: yarn install --immutable --immutable-cache --check-cache

Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
upload_debug_symbols:
needs: build
name: 'Upload debug symbols'
runs-on: windows-latest
runs-on: windows-2022
if: startsWith(github.ref, 'refs/tags/')
steps:
- name: Get the version of aws cli
Expand Down Expand Up @@ -142,7 +142,7 @@ jobs:
upload_release_package:
needs: build
name: 'Upload release package win'
runs-on: windows-latest
runs-on: windows-2022
if: startsWith(github.ref, 'refs/tags/')
env:
OS_TAG: "win64"
Expand Down Expand Up @@ -193,9 +193,9 @@ jobs:
run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_OUTPUT
shell: bash
- name: Install Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: '16.x'
node-version: '24.x'
- name: Install dependencies
run: yarn install --immutable --immutable-cache --check-cache
- name: Prepare translations
Expand Down
2 changes: 1 addition & 1 deletion crash-handler-module/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ project(crash-handler)

SET(NODEJS_URL "https://artifacts.electronjs.org/headers/dist" CACHE STRING "Node.JS URL")
SET(NODEJS_NAME "iojs" CACHE STRING "Node.JS Name")
SET(NODEJS_VERSION "v29.4.3" CACHE STRING "Node.JS Version")
SET(NODEJS_VERSION "v43.2.0" CACHE STRING "Node.JS Version")
Comment on lines 4 to +6

include(NodeJS)
include(CPack)
Expand Down
Loading